From 3e002b9a38b731ef379ae881d1078fc66a217dec Mon Sep 17 00:00:00 2001 From: Porya Isfahani Date: Tue, 20 Jan 2026 10:47:19 -0500 Subject: [PATCH 1/4] add signing tests --- .../integration/SigningDocumentTest.java | 84 +++++++++++++++++++ .../java/com/onfido/integration/TestBase.java | 6 ++ 2 files changed, 90 insertions(+) create mode 100644 src/test/java/com/onfido/integration/SigningDocumentTest.java diff --git a/src/test/java/com/onfido/integration/SigningDocumentTest.java b/src/test/java/com/onfido/integration/SigningDocumentTest.java new file mode 100644 index 00000000..4cef9ad9 --- /dev/null +++ b/src/test/java/com/onfido/integration/SigningDocumentTest.java @@ -0,0 +1,84 @@ +package com.onfido.integration; + +import com.onfido.ApiException; +import com.onfido.FileTransfer; +import com.onfido.model.Applicant; +import com.onfido.model.SigningDocument; +import java.util.List; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +public class SigningDocumentTest extends TestBase { + private Applicant applicant; + private SigningDocument signingDocument; + + @BeforeEach + public void setupTest() throws Exception { + applicant = createApplicant(); + signingDocument = uploadSigningDocument(applicant, "sample_signing_document.pdf"); + } + + @Test + public void uploadSigningDocumentTest() { + Assertions.assertEquals("sample_signing_document.pdf", signingDocument.getFileName()); + Assertions.assertEquals("pdf", signingDocument.getFileType()); + Assertions.assertEquals(applicant.getId(), signingDocument.getApplicantId()); + Assertions.assertNotNull(signingDocument.getHref()); + Assertions.assertNotNull(signingDocument.getDownloadHref()); + Assertions.assertTrue(signingDocument.getFileSize() > 0); + Assertions.assertNotNull(signingDocument.toJson()); + } + + @Test + public void downloadSigningDocumentTest() throws Exception { + FileTransfer download = onfido.downloadSigningDocument(signingDocument.getId()); + + Assertions.assertEquals("application/pdf", download.getContentType()); + Assertions.assertNotNull(download.getFilename()); + Assertions.assertEquals("%PDF", new String(download.getByteArray(), 0, 4)); + Assertions.assertTrue(download.getByteArray().length > 0); + } + + @Test + public void findSigningDocumentTest() throws Exception { + SigningDocument found = onfido.findSigningDocument(signingDocument.getId()); + + Assertions.assertEquals(signingDocument.getId(), found.getId()); + Assertions.assertEquals("sample_signing_document.pdf", found.getFileName()); + Assertions.assertEquals("pdf", found.getFileType()); + Assertions.assertEquals(applicant.getId(), found.getApplicantId()); + Assertions.assertNotNull(found.getDownloadHref()); + Assertions.assertNotNull(found.toJson()); + } + + @Test + public void listSigningDocumentsTest() throws Exception { + List documents = + onfido.listSigningDocuments(applicant.getId()).getDocuments(); + + Assertions.assertNotNull(documents); + Assertions.assertTrue( + documents.stream().anyMatch(d -> d.getId().equals(signingDocument.getId()))); + } + + @Test + public void uploadSigningDocumentNullParamsTest() { + try { + onfido.uploadSigningDocument(null, null); + Assertions.fail(); + } catch (ApiException ex) { + Assertions.assertEquals(0, ex.getCode()); + } + } + + @Test + public void downloadSigningDocumentErrorTest() { + try { + onfido.downloadSigningDocument(nonExistingId); + Assertions.fail(); + } catch (ApiException ex) { + Assertions.assertEquals(404, ex.getCode()); + } + } +} diff --git a/src/test/java/com/onfido/integration/TestBase.java b/src/test/java/com/onfido/integration/TestBase.java index c9468705..8a478055 100644 --- a/src/test/java/com/onfido/integration/TestBase.java +++ b/src/test/java/com/onfido/integration/TestBase.java @@ -94,6 +94,12 @@ protected Document uploadDocument( locationBuilder); } + protected SigningDocument uploadSigningDocument(Applicant applicant, String filename) + throws ApiException { + return onfido.uploadSigningDocument( + applicant.getId(), new FileTransfer(new File("media/" + filename))); + } + protected LivePhoto uploadLivePhoto(Applicant applicant, String filename) throws Exception { return onfido.uploadLivePhoto( applicant.getId(), new FileTransfer(new File("media/" + filename)), true); From 17e2ed7d3ad322e8e221441b2603453aee459c4b Mon Sep 17 00:00:00 2001 From: Porya Isfahani Date: Tue, 20 Jan 2026 11:10:23 -0500 Subject: [PATCH 2/4] update method name --- src/test/java/com/onfido/integration/SigningDocumentTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/onfido/integration/SigningDocumentTest.java b/src/test/java/com/onfido/integration/SigningDocumentTest.java index 4cef9ad9..ba1842c0 100644 --- a/src/test/java/com/onfido/integration/SigningDocumentTest.java +++ b/src/test/java/com/onfido/integration/SigningDocumentTest.java @@ -55,7 +55,7 @@ public void findSigningDocumentTest() throws Exception { @Test public void listSigningDocumentsTest() throws Exception { List documents = - onfido.listSigningDocuments(applicant.getId()).getDocuments(); + onfido.listSigningDocuments(applicant.getId()).getSigningDocuments(); Assertions.assertNotNull(documents); Assertions.assertTrue( From a03fef0294a4f96ad64105915f4f5d83955e2d48 Mon Sep 17 00:00:00 2001 From: Porya Isfahani Date: Tue, 20 Jan 2026 11:20:33 -0500 Subject: [PATCH 3/4] add sample pdf --- media/sample_signing_document.pdf | Bin 0 -> 3164 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 media/sample_signing_document.pdf diff --git a/media/sample_signing_document.pdf b/media/sample_signing_document.pdf new file mode 100644 index 0000000000000000000000000000000000000000..aceafc9e522c019c5b5b9d49c8a8aaf34acf2a96 GIT binary patch literal 3164 zcmeH~(N4lJ6o&8n6z67%UdYzLh9qPcAjCwC1a?QbD6E?$(3-9@=u3Lx8|aI8x&b1- zfoZR{zyIku{ja`ylbi7sZFPwE`St!mCjVi#Ou!5HmqG1Y2 zLb%MV(f8XInBz z@f-@Mr8#u5ZxBG5!Np7zQpf@_wW_vuQh}2cni-)a7+xC4#m-ckx4>Cl0xkiUfJ?w7 z;1X~NxCH)b0+*1kVU$`X-qYirjxBs1Ftfqw8cqFKwKO$dTM-#~z)Ifi-15x}H)6$3 zV0EW?PLO^{a9j{aQ9FVhjvB>Yc7goSV#M4tjfRN$XIj|lo@-%`B5)skMl-SDx_%YR e#2begiCZa)_xsmCX_z+koMG=eAf7jR9FuPY>2c)% literal 0 HcmV?d00001 From fd5f00ec2bf8928700b2f0f11fdd8f8c5df4701e Mon Sep 17 00:00:00 2001 From: Porya Isfahani Date: Wed, 21 Jan 2026 07:46:36 -0500 Subject: [PATCH 4/4] formatting --- src/test/java/com/onfido/integration/SigningDocumentTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/onfido/integration/SigningDocumentTest.java b/src/test/java/com/onfido/integration/SigningDocumentTest.java index ba1842c0..cf3d6cdf 100644 --- a/src/test/java/com/onfido/integration/SigningDocumentTest.java +++ b/src/test/java/com/onfido/integration/SigningDocumentTest.java @@ -55,7 +55,7 @@ public void findSigningDocumentTest() throws Exception { @Test public void listSigningDocumentsTest() throws Exception { List documents = - onfido.listSigningDocuments(applicant.getId()).getSigningDocuments(); + onfido.listSigningDocuments(applicant.getId()).getSigningDocuments(); Assertions.assertNotNull(documents); Assertions.assertTrue(