From 1699274f66d8c7d3a9ce61e185699d27b7737140 Mon Sep 17 00:00:00 2001 From: Aaron Gibson Date: Mon, 1 Dec 2025 15:01:32 +0100 Subject: [PATCH 1/2] add notes about response size limitations to hhfm, dash, and ndt7 --- nettests/ts-006-header-field-manipulation.md | 6 ++++++ nettests/ts-021-dash.md | 6 ++++++ nettests/ts-022-ndt.md | 4 ++++ 3 files changed, 16 insertions(+) diff --git a/nettests/ts-006-header-field-manipulation.md b/nettests/ts-006-header-field-manipulation.md index 88172a23..a0921bb1 100644 --- a/nettests/ts-006-header-field-manipulation.md +++ b/nettests/ts-006-header-field-manipulation.md @@ -207,6 +207,12 @@ headers not present in both the sent and received headers. } ``` +# Limitations + +The maximum response size is limited to 128 megabytes in order to not consume excessive +memory on the host device. This is believed to be a conservative maximum bounds +which should not be exceeded in normal usage. + # Privacy considerations If the user is behind a transparent HTTP proxy that sets the X-Forwarded-For diff --git a/nettests/ts-021-dash.md b/nettests/ts-021-dash.md index 3d2327bd..0708d1dd 100644 --- a/nettests/ts-021-dash.md +++ b/nettests/ts-021-dash.md @@ -164,6 +164,8 @@ used by OONI Probe: in reality because a server cannot encode a video into all the possible bitrates, but is useful to measure network performance, as explained below). +- each response may not exceed 128 megabytes in size. + ## Rationale of selected parameters The initial bitrate estimate is set to 3,000 kbit/s because that @@ -194,6 +196,10 @@ speed with which the last segment was downloaded. In OONI Probe, we decided to disable this behavior by default, so to better measure the network quality. +Response sizes are limited to 128 megabytes in order to not consume excessive +memory on the host device. This is believed to be a conservative maximum bounds +which should not be exceeded in normal usage. + # Expected output ## Parent data format diff --git a/nettests/ts-022-ndt.md b/nettests/ts-022-ndt.md index fc13cc9c..5641a513 100644 --- a/nettests/ts-022-ndt.md +++ b/nettests/ts-022-ndt.md @@ -43,6 +43,10 @@ the following features. Ndt5 tests have a `"test_s2c"` key that is not present inside of ndt7 tests. Ndt7 clients also include a key that is called `"protocol"` and is set to `7`. +Response size of each segment is limited to 128 megabytes in order to not +consume excessive memory on the host device. This is believed to be a +conservative maximum bounds which should not be exceeded in normal usage. + # Expected output ## Parent data format From f4dc7b4261cffabe45d69aeaf3c035325c59e922 Mon Sep 17 00:00:00 2001 From: Aaron Gibson Date: Mon, 1 Dec 2025 15:05:48 +0100 Subject: [PATCH 2/2] bump spec version numbers of hhfm, dash, and ndt7 --- nettests/ts-006-header-field-manipulation.md | 2 +- nettests/ts-021-dash.md | 2 +- nettests/ts-022-ndt.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nettests/ts-006-header-field-manipulation.md b/nettests/ts-006-header-field-manipulation.md index a0921bb1..6197e97b 100644 --- a/nettests/ts-006-header-field-manipulation.md +++ b/nettests/ts-006-header-field-manipulation.md @@ -1,6 +1,6 @@ # Specification version number -0.2.1 +0.2.2 * _status_: current diff --git a/nettests/ts-021-dash.md b/nettests/ts-021-dash.md index 0708d1dd..2a8b5fcd 100644 --- a/nettests/ts-021-dash.md +++ b/nettests/ts-021-dash.md @@ -1,6 +1,6 @@ # Specification version number -2020-04-20-001 +2025-12-01-001 * _status_: current diff --git a/nettests/ts-022-ndt.md b/nettests/ts-022-ndt.md index 5641a513..8abc892a 100644 --- a/nettests/ts-022-ndt.md +++ b/nettests/ts-022-ndt.md @@ -1,6 +1,6 @@ # Specification version number -2020-04-08-001 +2025-12-01-001 * _status_: current