From 50d964a045032a18f50fc401a90a159c0fc541ab Mon Sep 17 00:00:00 2001 From: Dylan Russell Date: Tue, 16 Dec 2025 20:12:31 +0000 Subject: [PATCH 1/2] Add log message --- .../src/opentelemetry/util/genai/_upload/__init__.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py b/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py index 9ef0a08efb..77f468fa14 100644 --- a/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py +++ b/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py @@ -49,6 +49,9 @@ def upload_completion_hook() -> CompletionHook: UploadCompletionHook, ) except ImportError: + _logger.exception( + "Failed to import `fsspec`. Falling back to `NoOpCompletionHook` which does nothing." + ) return _NoOpCompletionHook() environ_max_queue_size = environ.get( From 48e0456db48c902e8a79796a526cd02bfab00aab Mon Sep 17 00:00:00 2001 From: Dylan Russell Date: Tue, 23 Dec 2025 15:21:49 +0000 Subject: [PATCH 2/2] Add changelog, adjust err msg --- util/opentelemetry-util-genai/CHANGELOG.md | 1 + .../src/opentelemetry/util/genai/_upload/__init__.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/util/opentelemetry-util-genai/CHANGELOG.md b/util/opentelemetry-util-genai/CHANGELOG.md index 0c477e3ca3..2622a18ed9 100644 --- a/util/opentelemetry-util-genai/CHANGELOG.md +++ b/util/opentelemetry-util-genai/CHANGELOG.md @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +- Log error when `fsspec` fails to be imported instead of silently failing ([#4037](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4037)). - Minor change to check LRU cache in Completion Hook before acquiring semaphore/thread ([#3907](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3907)). - Add environment variable for genai upload hook queue size ([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3943](#3943)) diff --git a/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py b/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py index 77f468fa14..d52cde56e9 100644 --- a/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py +++ b/util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py @@ -50,7 +50,7 @@ def upload_completion_hook() -> CompletionHook: ) except ImportError: _logger.exception( - "Failed to import `fsspec`. Falling back to `NoOpCompletionHook` which does nothing." + "Failed to import `fsspec`. Falling back to `NoOpCompletionHook`." ) return _NoOpCompletionHook()