Categories belonging to series are broken in combination with MCA #648
Description
Note: This is currently a WIP issue. The text below the fold will still be evolving until I remove this notice.
This replaces (at least) #634 and #601.
The root of the problem is that with the introduction of MCA, annotations no longer contain a copy of their label's data (title, color, ...). They merely refer to the label by its ID. That means we can no longer delete labels. Instead we just mark them as such.
That in combination with the fact that we regularly delete labels as part of the course of managing series categories/labels leads to the following problems.
- A few places were not updated to know about this or handle it correctly:
- Specifically the frontend still needs to fetch all the labels, even deleted ones, to be able to display them correctly on annotations, or we need to undertake a major refactoring. That also means that they need to be filtered in all the appropriate places. (Category editor, MCA modals, ...) See Filter deleted labels in the frontend #649.
- The part of the backend, that is responsible for the regular deletion of series labels as part of requesting them, actually hat a small bug where it marked the labels as deleted in the database, but still returned the unmarked labels. See Hide the fact that we are duplicating series labels better #651.
- The above fixes the superficial issues with the approach, but while the way we manage series categories and labels was weird before MCA, this now leads to infinite duplication. Series category labels are deleted and recreated every time they are requested for a video that is not the one where the category “originated.” That, in turn, happens at least every time someone opens/refreshes the tool to annotate such a video. I will explore this further in Change the way we handle series categories in a post-MCA world #652.