Incorrect ProbeSpecifier

[trombonehero]

documentation/specification/chap-opendtrace-dlang.tex

Line 151 in d89ccdb

<ProbeSpecifier> ::= <Identifier>

This part of the grammar says that a ProbeIdentifier is a colon-separated list of Identifiers, but that precludes:

• wildcards (e.g., perl*:::*-entry)
• specifiers that omit components but keep the colons (e.g., zfs::arc-shrink)
• specifiers without colons (e.g., entry)

[trombonehero]

@dstolfa : ^

[dstolfa]

The full definition of ProbeSpecifier is:

<ProbeSpecifier> ::= <Identifier>
                   | [ <Identifier> ] `:' [ <Identifier> ]
                   | [ <Identifier> ] `:' [ <Identifier> ] `:' [ <Identifier> ]
                   | [ <Identifier> ] `:' [ <Identifier> ] `:' [ <Identifier> ] `:' [ <Identifier> ]

In general, I might have overlooked something, but my understanding is as follows:

• For wildcards, I've overlooked the possibility of using '+', '*' and the likes. This should be fixed.
• Specifiers that omit components but keep colons such as zfs::arc-shrink are actually treated as :zfs::arc-shrink and should be handled by the case where we have 3 optionally specified <Identifier>s separated by colons, which is the third case syntactically (or if transformed to "canonical" form beforehand e.g. :zfs::arc-shrink by the fourth case) unless I'm missing something.
• As for specifiers without colons, that should be handled by the first case, as something like entry matches <Identifier>, and if transformed to the "canonical" form :::entry, matches the fourth case with 4 optional identifiers separated by colons.

If I have overlooked anything else other than the wildcards (or my understanding of the syntax isn't correct), I'm happy to fix it as soon as I have the correct understanding of it :).