From d288ff9d3e77c4152e0146b368d22959d1c6b0a2 Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Tue, 12 Apr 2022 12:23:41 +0500 Subject: [PATCH 1/2] feat: remove feature flag for pathways --- .../src/LearningTypeRadioFacet.jsx | 28 ++++++++----------- packages/catalog-search/src/config/index.js | 4 --- .../src/tests/LearningTypeRadioFacet.test.jsx | 3 -- 3 files changed, 12 insertions(+), 23 deletions(-) diff --git a/packages/catalog-search/src/LearningTypeRadioFacet.jsx b/packages/catalog-search/src/LearningTypeRadioFacet.jsx index fae0043f..289f1525 100644 --- a/packages/catalog-search/src/LearningTypeRadioFacet.jsx +++ b/packages/catalog-search/src/LearningTypeRadioFacet.jsx @@ -70,22 +70,18 @@ const LearningTypeRadioFacet = () => { Programs - { - features.ENABlE_PATHWAYS && ( - - handleInputOnChange(LEARNING_TYPE_PATHWAY)} - data-testid="learning-type-pathways" - /> - - Pathways - - - ) - } + + handleInputOnChange(LEARNING_TYPE_PATHWAY)} + data-testid="learning-type-pathways" + /> + + Pathways + + diff --git a/packages/catalog-search/src/config/index.js b/packages/catalog-search/src/config/index.js index 9b7b3148..7fd5a229 100644 --- a/packages/catalog-search/src/config/index.js +++ b/packages/catalog-search/src/config/index.js @@ -4,7 +4,6 @@ export const FEATURE_ENROLL_WITH_CODES = 'ENROLL_WITH_CODES'; export const FEATURE_LANGUAGE_FACET = 'LANGUAGE_FACET'; export const FEATURE_PROGRAM_TITLES_FACET = 'PROGRAM_TITLES_FACET'; export const LEARNING_TYPE_FACET = 'LEARNING_TYPE_FACET'; -export const FEATURE_ENABLE_PATHWAYS = 'ENABLE_PATHWAYS'; // eslint-disable-next-line import/prefer-default-export export const features = { @@ -16,7 +15,4 @@ export const features = { LEARNING_TYPE_FACET: ( process.env.LEARNING_TYPE_FACET || hasFeatureFlagEnabled(LEARNING_TYPE_FACET) ), - ENABlE_PATHWAYS: ( - process.env.FEATURE_ENABLE_PATHWAYS || hasFeatureFlagEnabled(FEATURE_ENABLE_PATHWAYS) - ), }; diff --git a/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx b/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx index 6a6782b9..19ebda4f 100644 --- a/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx +++ b/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx @@ -10,9 +10,6 @@ import { features } from '../config'; import { renderWithSearchContext } from './utils'; describe('', () => { - beforeEach(() => { - features.ENABlE_PATHWAYS = true; - }); test('LearningTypeRadioFacet is rendered and isnt bold initially', () => { renderWithSearchContext(); From 8716865b57ae4947bb9af87debea86ca72d2c1db Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Tue, 12 Apr 2022 12:30:19 +0500 Subject: [PATCH 2/2] refactor: remove unused imports --- packages/catalog-search/src/LearningTypeRadioFacet.jsx | 1 - .../catalog-search/src/tests/LearningTypeRadioFacet.test.jsx | 2 -- 2 files changed, 3 deletions(-) diff --git a/packages/catalog-search/src/LearningTypeRadioFacet.jsx b/packages/catalog-search/src/LearningTypeRadioFacet.jsx index 289f1525..c81b3bd0 100644 --- a/packages/catalog-search/src/LearningTypeRadioFacet.jsx +++ b/packages/catalog-search/src/LearningTypeRadioFacet.jsx @@ -5,7 +5,6 @@ import { SearchContext } from './SearchContext'; import { setRefinementAction, } from './data/actions'; -import { features } from './config'; import { LEARNING_TYPE_COURSE, LEARNING_TYPE_PROGRAM, LEARNING_TYPE_PATHWAY } from './data/constants'; const LearningTypeRadioFacet = () => { diff --git a/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx b/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx index 19ebda4f..6ef80f59 100644 --- a/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx +++ b/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx @@ -6,11 +6,9 @@ import '@testing-library/jest-dom/extend-expect'; import LearningTypeRadioFacet from '../LearningTypeRadioFacet'; -import { features } from '../config'; import { renderWithSearchContext } from './utils'; describe('', () => { - test('LearningTypeRadioFacet is rendered and isnt bold initially', () => { renderWithSearchContext(); expect(screen.getByText('Learning Type')).toBeInTheDocument();