From cddfda5b959895312f45dfd9625702fcdb24981a Mon Sep 17 00:00:00 2001
From: mariagrimaldi <maria.grimaldi@edunext.co>
Date: Mon, 7 Jun 2021 18:05:11 -0400
Subject: [PATCH 1/2] feat: add Open edX signal definitions V1

---
 openedx_events/learning/signals.py | 81 ++++++++++++++++++++++++++++++
 1 file changed, 81 insertions(+)

diff --git a/openedx_events/learning/signals.py b/openedx_events/learning/signals.py
index e842c1d2..cc0e4b10 100644
--- a/openedx_events/learning/signals.py
+++ b/openedx_events/learning/signals.py
@@ -7,3 +7,84 @@
 They also must comply with the payload definition specified in
 docs/decisions/0003-events-payload.rst
 """
+
+from openedx_events.learning.data import (
+    CertificateData,
+    CohortData,
+    CourseEnrollmentData,
+    RegistrationFormData,
+    StudentData,
+)
+from openedx_events.tooling import OpenEdxPublicSignal
+
+STUDENT_REGISTRATION_COMPLETED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.student.registration.completed.v1",
+    data={
+        "user": StudentData,
+        "registration_form": RegistrationFormData,
+    }
+)
+
+
+SESSION_LOGIN_COMPLETED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.auth.session.login.completed.v1",
+    data={
+        "user": StudentData,
+    }
+)
+
+
+COURSE_ENROLLMENT_CREATED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.course.enrollment.created.v1",
+    data={
+        "enrollment": CourseEnrollmentData,
+    }
+)
+
+
+COURSE_ENROLLMENT_CHANGED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.course.enrollment.changed.v1",
+    data={
+        "enrollment": CourseEnrollmentData,
+    }
+)
+
+
+COURSE_ENROLLMENT_DEACTIVATED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.course.enrollment.deactivated.v1",
+    data={
+        "enrollment": CourseEnrollmentData,
+    }
+)
+
+
+CERTIFICATE_CREATED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.certificate.created.v1",
+    data={
+        "certificate": CertificateData,
+    }
+)
+
+
+CERTIFICATE_CHANGED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.certificate.changed.v1",
+    data={
+        "certificate": CertificateData,
+    }
+)
+
+
+CERTIFICATE_REVOKED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.certificate.revoked.v1",
+    data={
+        "certificate": CertificateData,
+    }
+)
+
+
+COHORT_MEMBERSHIP_CHANGED = OpenEdxPublicSignal(
+    event_type="org.openedx.learning.cohort_membership.changed.v1",
+    data={
+        "cohort": CohortData,
+    }
+)

From 7f468a2122be9e6ff7d3d7694b5efedcaca07f8a Mon Sep 17 00:00:00 2001
From: mariagrimaldi <maria.grimaldi@edunext.co>
Date: Mon, 19 Jul 2021 14:19:29 -0400
Subject: [PATCH 2/2] fix: addressing PR comments

---
 openedx_events/learning/signals.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/openedx_events/learning/signals.py b/openedx_events/learning/signals.py
index cc0e4b10..67d74933 100644
--- a/openedx_events/learning/signals.py
+++ b/openedx_events/learning/signals.py
@@ -13,14 +13,14 @@
     CohortData,
     CourseEnrollmentData,
     RegistrationFormData,
-    StudentData,
+    UserData,
 )
 from openedx_events.tooling import OpenEdxPublicSignal
 
 STUDENT_REGISTRATION_COMPLETED = OpenEdxPublicSignal(
     event_type="org.openedx.learning.student.registration.completed.v1",
     data={
-        "user": StudentData,
+        "user": UserData,
         "registration_form": RegistrationFormData,
     }
 )
@@ -29,7 +29,7 @@
 SESSION_LOGIN_COMPLETED = OpenEdxPublicSignal(
     event_type="org.openedx.learning.auth.session.login.completed.v1",
     data={
-        "user": StudentData,
+        "user": UserData,
     }
 )
 
@@ -50,7 +50,7 @@
 )
 
 
-COURSE_ENROLLMENT_DEACTIVATED = OpenEdxPublicSignal(
+COURSE_UNENROLLMENT_COMPLETED = OpenEdxPublicSignal(
     event_type="org.openedx.learning.course.enrollment.deactivated.v1",
     data={
         "enrollment": CourseEnrollmentData,