From fa52894c3d7a7f8b1974fc9558c6498f33d4f09c Mon Sep 17 00:00:00 2001 From: StephDriver <5330770+StephDriver@users.noreply.github.com> Date: Fri, 23 Jan 2026 11:27:36 +0000 Subject: [PATCH 1/4] a11y: #5105 update credit link markup for screen-readers --- src/themes/OLH/templates/journal/article.html | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/themes/OLH/templates/journal/article.html b/src/themes/OLH/templates/journal/article.html index bbdd15e95b..9a86f0bb98 100644 --- a/src/themes/OLH/templates/journal/article.html +++ b/src/themes/OLH/templates/journal/article.html @@ -480,7 +480,13 @@

{% trans "File Checksums" %} (MD5)

{% if journal_settings.general.use_credit and author.credits.exists %}
-

{% trans "CRediT Roles" %}

+

{% trans "CRediT Roles" %} + + {% trans "Read more about Credit." %} + + {% include "elements/icons/link_external.html" %} + +

- {% if journal_settings.general.use_credit and author.credits.exists %} -
-

{% trans "CRediT Roles" %} - - {% trans "Read more about Credit." %} - - {% include "elements/icons/link_external.html" %} - -

- +
+ {% endif %} + {% endfor %} {% endif %}
From 7df7f88672ac23e705cf020c054f8e72d5c052f5 Mon Sep 17 00:00:00 2001 From: StephDriver <5330770+StephDriver@users.noreply.github.com> Date: Fri, 13 Feb 2026 11:31:00 +0000 Subject: [PATCH 3/4] bugfix: credit displaying twice on OLH article --- src/journal/views.py | 5 ++++ src/themes/OLH/templates/journal/article.html | 28 ++++++++----------- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/src/journal/views.py b/src/journal/views.py index e9491ad805..2bc9737e3c 100755 --- a/src/journal/views.py +++ b/src/journal/views.py @@ -496,6 +496,10 @@ def article(request, identifier_type, identifier): file__mime_type="text/html", ) + credit_records_exist = submission_models.CreditRecord.objects.filter( + frozen_author__article=article_object + ).exists() + template = "journal/article.html" context = { "article": article_object, @@ -504,6 +508,7 @@ def article(request, identifier_type, identifier): "identifier": identifier, "article_content": content, "tables_in_galley": tables_in_galley, + "credit_records_exist": credit_records_exist, } return render(request, template, context) diff --git a/src/themes/OLH/templates/journal/article.html b/src/themes/OLH/templates/journal/article.html index 06edb2a651..a0f2a6ff45 100644 --- a/src/themes/OLH/templates/journal/article.html +++ b/src/themes/OLH/templates/journal/article.html @@ -478,18 +478,16 @@

{% trans "File Checksums" %} (MD5)

{% endif %}
- {% if journal_settings.general.use_credit %} - {% for author_check in article.frozen_authors.all %} - {% if author_check.credits.exists %} -
-

{% trans "CRediT Roles" %} - - {% trans "Read more about Credit." %} - - {% include "elements/icons/link_external.html" %} - -

- +
{% endif %}
From 2fc5e3c8688db9fd6762b074a031e39224c52f8a Mon Sep 17 00:00:00 2001 From: StephDriver <5330770+StephDriver@users.noreply.github.com> Date: Fri, 13 Feb 2026 11:43:40 +0000 Subject: [PATCH 4/4] a11y: #5105 change credit link to read more --- src/themes/OLH/templates/journal/article.html | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/themes/OLH/templates/journal/article.html b/src/themes/OLH/templates/journal/article.html index a0f2a6ff45..b1878be0d1 100644 --- a/src/themes/OLH/templates/journal/article.html +++ b/src/themes/OLH/templates/journal/article.html @@ -480,13 +480,7 @@

{% trans "File Checksums" %} (MD5)

{% if journal_settings.general.use_credit and credit_records_exist %}
-

{% trans "CRediT Roles" %} - - {% trans "Read more about Credit." %} - - {% include "elements/icons/link_external.html" %} - -

+

{% trans "CRediT Roles" %}

+ + {% trans "Read More" %} + {% include "elements/icons/link_external.html" %} +
{% endif %}