Skip to content

Commit 6efa01b

Browse files
committed
DO NOT MERGE more installer patching to make tests pass
1 parent d57694a commit 6efa01b

File tree

5 files changed

+18
-14
lines changed

5 files changed

+18
-14
lines changed

pkg/controller/machinepool/azureactuator_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,9 @@ func TestAzureActuator(t *testing.T) {
197197
generateAzureMachineSetName("zone2"): 1,
198198
generateAzureMachineSetName("zone3"): 1,
199199
},
200-
// V1 image is chosen for machinepool
200+
// Empty image is chosen for machinepool, and MAO will decide
201201
expectedImage: &machineapi.Image{
202-
ResourceID: "/resourceGroups/foo-12345-rg/providers/Microsoft.Compute/galleries/gallery_foo_12345/images/foo-12345/versions/latest",
202+
ResourceID: "",
203203
},
204204
},
205205
{
@@ -216,9 +216,9 @@ func TestAzureActuator(t *testing.T) {
216216
generateAzureMachineSetName("zone2"): 1,
217217
generateAzureMachineSetName("zone3"): 1,
218218
},
219-
// V1 image is chosen for machinepool
219+
// Empty image is chosen for machinepool, and MAO will decide
220220
expectedImage: &machineapi.Image{
221-
ResourceID: "/resourceGroups/foo-12345-rg/providers/Microsoft.Compute/galleries/gallery_foo_12345/images/foo-12345/versions/latest",
221+
ResourceID: "",
222222
},
223223
},
224224
{
@@ -235,9 +235,9 @@ func TestAzureActuator(t *testing.T) {
235235
generateAzureMachineSetName("zone2"): 1,
236236
generateAzureMachineSetName("zone3"): 1,
237237
},
238-
// V2 ("-gen2") image is chosen for machinepool
238+
// Empty image is chosen for machinepool, and MAO will decide
239239
expectedImage: &machineapi.Image{
240-
ResourceID: "/resourceGroups/foo-12345-rg/providers/Microsoft.Compute/galleries/gallery_foo_12345/images/foo-12345-gen2/versions/latest",
240+
ResourceID: "",
241241
},
242242
},
243243
{
@@ -254,9 +254,9 @@ func TestAzureActuator(t *testing.T) {
254254
generateAzureMachineSetName("zone2"): 1,
255255
generateAzureMachineSetName("zone3"): 1,
256256
},
257-
// V2 ("-gen2") image is chosen for machinepool
257+
// Empty image is chosen for machinepool, and MAO will decide
258258
expectedImage: &machineapi.Image{
259-
ResourceID: "/resourceGroups/foo-12345-rg/providers/Microsoft.Compute/galleries/gallery_foo_12345/images/foo-12345-gen2/versions/latest",
259+
ResourceID: "",
260260
},
261261
},
262262
{

pkg/installmanager/testdata/install-config-with-existing-pull-secret.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ compute:
77
rootVolume:
88
iops: 100
99
size: 120
10+
throughput: 0
1011
type: gp3
1112
type: m5.xlarge
1213
replicas: 3
@@ -18,6 +19,7 @@ controlPlane:
1819
rootVolume:
1920
iops: 100
2021
size: 120
22+
throughput: 0
2123
type: gp3
2224
type: m5.xlarge
2325
replicas: 3

pkg/installmanager/testdata/install-config.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ compute:
77
rootVolume:
88
iops: 100
99
size: 120
10+
throughput: 0
1011
type: gp3
1112
type: m5.xlarge
1213
replicas: 3
@@ -18,6 +19,7 @@ controlPlane:
1819
rootVolume:
1920
iops: 100
2021
size: 120
22+
throughput: 0
2123
type: gp3
2224
type: m5.xlarge
2325
replicas: 3

vendor/github.com/openshift/installer/pkg/asset/machines/azure/azuremachines.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/openshift/installer/pkg/asset/machines/azure/machines.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)