Skip to content
This repository was archived by the owner on Sep 13, 2021. It is now read-only.
This repository was archived by the owner on Sep 13, 2021. It is now read-only.

Returning only modified cloud function. Not all cloud function #1

@rickmak

Description

@rickmak

Current implementation is to grep the changed files with pattern. Which is okay to return all cloud function to in a files.

There will be problem to apply this searching method to the patch files.

Scenario.
patch with the following

+     with _get_engine().begin() as conn:
+        trans = conn.begin()
+            conn.execute(sa.text('''SQL'''))

The patch file can contain no skygear.op declaration. But it modify the op function.

To achieve the goal, we will need to do a context analysis to see which function is got modify and see if that function is skygear.op or not. Cannot just grep the diff.

To make it happen, we need to parse the source code. We take a look at parser for python and Esprima for js

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions