review feedback

Author: jgallagher

internal-dns/src/names.rs

@@ -11,7 +11,7 @@ use omicron_uuid_kinds::{OmicronZoneUuid, SledUuid};
 /// chrony does not support SRV records. This name resolves to AAAA records for
 /// each boundary NTP zone, and then we can point internal NTP chrony instances
 /// at this name for it to find the boundary NTP zones.
-pub const BOUNDARY_NTP_DNS_NAME: &str = "boundary.ntp";
+pub const BOUNDARY_NTP_DNS_NAME: &str = "boundary-ntp";
 
 /// Name for the control plane DNS zone
 pub const DNS_ZONE: &str = "control-plane.oxide.internal";

smf/chrony-setup/manifest.xml

@@ -25,9 +25,19 @@
   </property_group>
 
   <property_group name="config" type="application">
+    <!-- Whether this is a boundary or internal NTP zone -->
     <propval name="boundary" type="boolean" value="false" />
+    <!--
+      DNS name for the pool of boundary NTP servers. (Only used if this is
+      an internal NTP zone.)
+    -->
     <propval name="boundary_pool" type="astring" value="" />
+    <!--
+        Upstream NTP server. May be specifid more than once. (At least one is
+        required.)
+    -->
     <propval name="server" type="astring" value="" />
+    <!-- Allowed IPv6 range for clients (typically the rack subnet) -->
     <propval name="allow" type="astring" value="" />
   </property_group>