Skip to content

Remove the need of fragments introduced by the source line number feature #23

@tbatchelli

Description

@tbatchelli

The introduction of source line numbers in the generated script created a new issue, scripts are not composable outside of stevedore (e.g. https://github.com/pallet/pallet/blob/develop/src/pallet/crate/etc_hosts.clj#L115 where the file name is generated via stevedore).

The problem is that the way comments work in bash make this kind of composition impossible, as anything after the comment is ignored. Since now stevedore adds the line numbers as comments, we needed a way to generate scripts without these line numbers.

A better solution could be to have stevedore proactively sanitize these 'included' scripts by removing comments. This way, we could still regular stevedore scripts without needing the special case of 'fragments'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions