Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

Payable modifier should throw #9

@czepluch

Description

@czepluch

IMO a modifier checking a value on a payable function should throw and not return. Currently people paying 0.029 ether would not get notified that their attempt was unsuccessful and 0.029 ether would just be transferred to the smart contract. Transferring another 0.001 ether would not make the request successful. So I suggest that this (https://github.com/paritytech/contracts/blob/58842b9/SMSVerification.sol#L57) line should throw instead of returning.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions