Skip to content

ensure materialise and linearise preserves aux #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpbrodrick89 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ensure materialise and linearise preserves aux #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions lineax/_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,9 +1863,19 @@ def _(operator, transform=transform):
def _(operator, transform=transform):
return transform(operator.operator) / operator.scalar

@transform.register(AuxLinearOperator) # pyright: ignore

# diagonal strips aux (returns array, not operator)
@diagonal.register(AuxLinearOperator)
def _(operator):
return diagonal(operator.operator)


# linearise and materialise preserve aux
for transform in (linearise, materialise):

@transform.register(AuxLinearOperator)
def _(operator, transform=transform):
return transform(operator.operator)
return AuxLinearOperator(transform(operator.operator), operator.aux)


@linearise.register(TangentLinearOperator)
Expand Down Expand Up @@ -1934,11 +1944,21 @@ def _(operator):

@linearise.register(ComposedLinearOperator)
def _(operator):
# If the first operator has aux, preserve it on the result
if isinstance(operator.operator1, AuxLinearOperator):
aux = operator.operator1.aux
inner_composed = operator.operator1.operator @ operator.operator2
return AuxLinearOperator(linearise(inner_composed), aux)
return linearise(operator.operator1) @ linearise(operator.operator2)


@materialise.register(ComposedLinearOperator)
def _(operator):
# If the first operator has aux, preserve it on the result
if isinstance(operator.operator1, AuxLinearOperator):
aux = operator.operator1.aux
inner_composed = operator.operator1.operator @ operator.operator2
return AuxLinearOperator(materialise(inner_composed), aux)
return materialise(operator.operator1) @ materialise(operator.operator2)


Expand Down
Loading