Skip to content

Use file names for hash keys instead of the song ID. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjoy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use file names for hash keys instead of the song ID. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions mingus.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ This is used by `mingus-refresh'.")
:size 1000)
"Cache for song strings according to `mingus-playlist-format' and propertized for use in playlist.

Songs are hashed by their MPD ids.")
Songs are hashed by their file names.")
(defvar mingus-song-strings
(make-hash-table :test 'eq
:size 1000)
Expand Down Expand Up @@ -1650,7 +1650,7 @@ database may work."
new-results))))))

(defun mingus-pos->id (pos)
(getf (car (mingus-get-songs (format "playlistinfo %d" pos))) 'Id))
(getf (car (mingus-get-songs (format "playlistinfo %d" pos))) 'file))

(defun mingus-id->pos (id)
(getf (car (mingus-get-songs (format "playlistid %d" id))) 'Pos))
Expand Down Expand Up @@ -2254,7 +2254,7 @@ Optional argument REFRESH means not matter what is the status, do a refresh"
;non-unique vorbiscomment tags
(mapconcat
(lambda (list)
(let ((id (plist-get list 'Id)))
(let ((id (plist-get list 'file)))
(or (gethash id mingus-propertized-song-strings)
(let ((val
(propertize
Expand Down Expand Up @@ -2289,7 +2289,7 @@ Optional argument REFRESH means not matter what is the status, do a refresh"

See the documentation for the variable `mingus-mode-line-format' for the
syntax of EXPRESSION."
(let ((id (plist-get plist 'Id)))
(let ((id (plist-get plist 'file)))
(or (gethash id mingus-song-strings)
(let ((val
(let (artist album title albumartist
Expand Down Expand Up @@ -2842,7 +2842,7 @@ Switch to *Mingus* buffer if necessary."
(nset-difference
(mapcar
(lambda (song-item)
(getf song-item 'Id))
(getf song-item 'file))
(mingus-get-songs "playlistinfo")) mingus-marked-list))
(mingus-playlist t)
)
Expand Down Expand Up @@ -2945,7 +2945,7 @@ deleted."
(mpd-delete mpd-inter-conn (set-difference
(loop for i in
(mingus-get-songs "playlistinfo")
collect (getf i 'Id))
collect (getf i 'file))
mingus-marked-list) t)
(mingus-playlist)
(message "Other songs deleted")))
Expand Down