Window Decoration

[rjhorniii]

Enhancement (easy)
Change the window decoration to match https://www.windowmaker.org/docs/chap2.html. These locations are very habitual muscle memory for long term users.

1. Title bar location on top
   a) miniaturize on the left edge
   b) close on the right edge.
2. Resize bar on bottom
   a) actually working to resize as a bonus.

This is part of a gradual list of features to add. It's prioritized by what order did I notice gaps when trying wlmaker.

[phkaeser]

For applications that support the xdg-decoration-unstable-v1 protocol, wlmaker should set the window decoration suitably:

Note: Miniaturize button is not wired up yet.

Playing with below setting in etc/wlmaker.plist applies that even for windows that support the protocol, but prefer to set own decoration:

  Decoration = {
    Mode = EnforceServer;
  };

Note: By default, Wayland applications provide their own decoration, and part of the client-owned surfaces. Only when supporting the xdg-decoration-unstable-v1 extension protocol can the compositor gracefully negotiate and apply own decoration.

(Example: The foot Terminal app)

[rjhorniii]

Ah, missed that. It's working for foot, but not for Firefox. It's also generating some errors in the log, so I'll see whether there's something else needed as well. Like perhaps the extension protocol is not properly supported on Tumbleweed?

[rjhorniii]

This is the relevant section of the log. It indicates an error, but that might be unrelated. The test input was to start wlmaker, then click firefox icon to start firefox. It starts and works properly, but without server decoration. This is with mode EnforceServer in etc/wlmaker.plist.

2025-05-16 16:46:59.279 (INFO) src/wlmaker.c:418 Starting Wayland compositor for server 0xc2bcb70 at wayland-1 ...
2025-05-16 16:46:59.281 (INFO) src/dock.c:174 Created dock 0xcf4ec60
2025-05-16 16:46:59.281 (INFO) src/clip.c:271 Created clip 0xcfcb020
2025-05-16 16:46:59.302 (INFO) src/xdg_toplevel.c:199 Created window 0xd01dd30 for wlmtk XDG toplevel surface 0xd01d7e0
2025-05-16 16:46:59.302 (INFO) src/xdg_shell.c:145 XDG shell: Toolkit window 0xd01dd30 for toplevel 0xce54da0
2025-05-16 16:46:59.302 (WARNING) src/xdg_toplevel.c:781 Unimplemented: set_app_id for XDG toplevel 0xd01d7e0
2025-05-16 16:46:59.302 (ERROR) types/xdg_shell/wlr_xdg_surface.c:169 A configure is scheduled for an uninitialized xdg_surface 0xcf616c0
2025-05-16 16:46:59.302 (INFO) src/xdg_decoration.c:315 XDG decoration request_mode for XDG surface 0xd01b8b0, content 0xd01d7e0: Current 0, pending 0, scheduled 2, requested 0. Set: 2
2025-05-16 16:46:59.302 (ERROR) types/xdg_shell/wlr_xdg_surface.c:169 A configure is scheduled for an uninitialized xdg_surface 0xcf616c0
2025-05-16 16:46:59.302 (INFO) src/xdg_decoration.c:315 XDG decoration request_mode for XDG surface 0xd01b8b0, content 0xd01d7e0: Current 0, pending 0, scheduled 2, requested 2. Set: 2
2025-05-16 16:47:02.547 (INFO) src/xdg_toplevel.c:199 Created window 0xd098f10 for wlmtk XDG toplevel surface 0xd0989c0
2025-05-16 16:47:02.547 (INFO) src/xdg_shell.c:145 XDG shell: Toolkit window 0xd098f10 for toplevel 0xd014a30
2025-05-16 16:47:02.547 (WARNING) src/xdg_toplevel.c:739 Unimplemented: set_parent for XDG toplevel 0xd0989c0
2025-05-16 16:47:02.547 (WARNING) src/xdg_toplevel.c:781 Unimplemented: set_app_id for XDG toplevel 0xd0989c0
2025-05-16 16:47:06.562 (INFO) src/xdg_toplevel.c:445 Destroying window 0xd0989c0 for wlmtk XDG surface 0xd098f10
2025-05-16 16:47:07.735 (INFO) src/launcher.c:440 App 'MOZ_ENABLE_WAYLAND=1 /usr/bin/firefox' (0xcfbfa40) terminated, status code 0.

[phkaeser]

To respond and set scope:

• The "Miniaturize" feature has not yet been implemented. Will be using this issue as tracking item, and added some detail in roadmap: Adds a detailed feature list. So far, document window handling. #251.

• Unfortunately, Firefox does not seem to implement the protocol for negotiating decoration behaviour (on my workstation, I don't get any "xdg_decoration.c" references after the launch of firefox. I'm using 128.8.0esr). Forcibly adding decorations won't look well, eg. wlmaker wouldn't be aware of the rounded corners.

The ERRORs in the log are, uh, me having been sloppy in following up on a recent protocol behaviour change in wlroots. These should be WARNINGs, actually.

[rjhorniii]

I'm using version 138.0.1. Under X11 it's allowing Windowmaker to decorate the window.

Is there an easy log I can turn on to check in wlmaker? This may be a Firefox issue. (That will be annoying.)

[phkaeser]

An application (running as XDG toplevel) will need to support the XDG decoration protocol in order to negotiate decorations and accept server-side (ie. give up client-side) decorations. On log level INFO (the default), this will be visible:

From the wlmaker side, that will show as a log entry as such, eg. when using /usr/bin/foot:

2025-05-18 09:59:16.732 (INFO) src/xdg_toplevel.c:199 Created window 0x563cf58ac9c0 for wlmtk XDG toplevel surface 0x563cf5899e90
[...]
2025-05-18 09:59:16.732 (INFO) src/xdg_decoration.c:315 XDG decoration request_mode for XDG surface 0x563cf589bb20, content 0x563cf5899e90: Current 0, pending 0, scheduled 2, requested 0. Set: 2
[...]
2025-05-18 09:59:19.521 (INFO) src/xdg_toplevel.c:445 Destroying window 0x563cf5899e90 for wlmtk XDG surface 0x563cf58ac9c0

The xdg_toplevel Created and Destroying messages indicate start + termination of the application.

Firefox: I have just tried with 138.0.4, but it doesn't appear to support the protocol:

2025-05-18 09:59:04.863 (INFO) src/xdg_toplevel.c:199 Created window 0x563cf581eb20 for wlmtk XDG toplevel surface 0x563cf58a0810
2025-05-18 09:59:04.863 (INFO) src/xdg_shell.c:145 XDG shell: Toolkit window 0x563cf581eb20 for toplevel 0x563cf55357d0
2025-05-18 09:59:04.863 (WARNING) src/xdg_toplevel.c:739 Unimplemented: set_parent for XDG toplevel 0x563cf58a0810
2025-05-18 09:59:04.863 (WARNING) src/xdg_toplevel.c:781 Unimplemented: set_app_id for XDG toplevel 0x563cf58a0810
2025-05-18 09:59:06.933 (WARNING) src/cursor.c:324 request_set_cursor called without pointer focus.
2025-05-18 09:59:10.756 (INFO) src/xdg_toplevel.c:445 Destroying window 0x563cf58a0810 for wlmtk XDG surface 0x563cf581eb20

Note the absence of the "XDG decoration" message.

I'm fairly confident this is a lacking feature in Firefox (eg. Chrome supports it, by enabling the "Use system title bar and borders" setting). Suggest to file a feature request to Firefox for that.

[tstraus13]

Firefox does allow for a title bar in the "Customize toolbar" menu/page. Screenshot attached showing how to enable. That may fix the issue you are running into here but not positive. I know I have had to enable that to get decorations from the DE/WM.