From cd18a3c13ad4e6362899375b7efbeaf08cfebe71 Mon Sep 17 00:00:00 2001 From: holtkamp Date: Fri, 30 Aug 2013 15:51:10 +0200 Subject: [PATCH 1/4] Made EntityManager flush operation Entity specific I encountered weird behavior where Entities were flushed to the database when I never intended to. It appeared I indicated the session to write and close at the end of PHP execution cycle. Because the EntityManager in the Doctrine Session SaveHandler, performs a general flush, all Entities are flushed, not only the Session Entity. --- lib/Pike/Session/SaveHandler/Doctrine.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Pike/Session/SaveHandler/Doctrine.php b/lib/Pike/Session/SaveHandler/Doctrine.php index 2a5b7e6..81a90c4 100644 --- a/lib/Pike/Session/SaveHandler/Doctrine.php +++ b/lib/Pike/Session/SaveHandler/Doctrine.php @@ -161,7 +161,7 @@ public function read($id) $return = $entity->getData(); } else { self::$em->remove($entity); - self::$em->flush(); + self::$em->flush($this->_entityName); } } @@ -186,7 +186,7 @@ public function write($id, $data) $entity->setModified(new DateTime('now')); self::$em->persist($entity); - self::$em->flush(); + self::$em->flush($this->_entityName); return true; } @@ -203,7 +203,7 @@ public function destroy($id) if ($entity instanceof Pike_Session_Entity_Interface) { self::$em->remove($entity); - self::$em->flush(); + self::$em->flush($this->_entityName); return true; } @@ -232,4 +232,4 @@ public function gc($maxlifetime) return true; } -} \ No newline at end of file +} From 2903333f58d501ccbfe84a969be849f2e2174d5c Mon Sep 17 00:00:00 2001 From: holtkamp Date: Fri, 30 Aug 2013 17:24:01 +0200 Subject: [PATCH 2/4] Made EntityManager flush the Entity, not the EntityName :( --- lib/Pike/Session/SaveHandler/Doctrine.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Pike/Session/SaveHandler/Doctrine.php b/lib/Pike/Session/SaveHandler/Doctrine.php index 81a90c4..6fbab31 100644 --- a/lib/Pike/Session/SaveHandler/Doctrine.php +++ b/lib/Pike/Session/SaveHandler/Doctrine.php @@ -161,7 +161,7 @@ public function read($id) $return = $entity->getData(); } else { self::$em->remove($entity); - self::$em->flush($this->_entityName); + self::$em->flush($entity); } } @@ -186,7 +186,7 @@ public function write($id, $data) $entity->setModified(new DateTime('now')); self::$em->persist($entity); - self::$em->flush($this->_entityName); + self::$em->flush($entity); return true; } @@ -203,7 +203,7 @@ public function destroy($id) if ($entity instanceof Pike_Session_Entity_Interface) { self::$em->remove($entity); - self::$em->flush($this->_entityName); + self::$em->flush($entity); return true; } From 7003443352fe4c1d0d40cee6fc8aef4df15b168b Mon Sep 17 00:00:00 2001 From: Menno Holtkamp Date: Sun, 26 Jan 2014 20:21:38 +0100 Subject: [PATCH 3/4] Delete composer.lock --- composer.lock | 29 ----------------------------- 1 file changed, 29 deletions(-) delete mode 100644 composer.lock diff --git a/composer.lock b/composer.lock deleted file mode 100644 index 08e31cb..0000000 --- a/composer.lock +++ /dev/null @@ -1,29 +0,0 @@ -{ - "hash": "96e65e511759d4647b91bf8018b7abce", - "packages": [ - { - "package": "doctrine/common", - "version": "2.2.2" - }, - { - "package": "doctrine/dbal", - "version": "2.2.2" - }, - { - "package": "doctrine/orm", - "version": "2.2.2" - }, - { - "package": "zendframework/zendframework1", - "version": "1.11.12" - } - ], - "packages-dev": null, - "aliases": [ - - ], - "minimum-stability": "stable", - "stability-flags": [ - - ] -} From 729beca4cf27a732c21c9a7718849af5150f3b99 Mon Sep 17 00:00:00 2001 From: Menno Holtkamp Date: Sun, 26 Jan 2014 20:22:46 +0100 Subject: [PATCH 4/4] Update composer.json Removed statements that are not responsibility of this package --- composer.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 92d3cc7..5a006e5 100644 --- a/composer.json +++ b/composer.json @@ -21,13 +21,11 @@ "require": { "php": ">=5.3", "doctrine/orm": "2.*", - "zendframework/zendframework1" : ">=1.11.11" + "zendframework/zendframework1" : "*" }, "autoload": { "psr-0": { - "doctrine/doctrine2" : "lib/", - "zendframework/zendframework1" : "library/", "Pike_" : "lib/" } },