Implement Type->toCoercedPropertyType() to replace inline coercion logic

phpstan-bot · staabm · claude · phpstan-bot · commit 2ca236415064 · 2026-02-17T14:14:26.000Z
Move int-to-float property coercion from NodeScopeResolver into the Type
system as toCoercedPropertyType(), following the same polymorphic pattern
as toCoercedArgumentType(). FloatType returns float|int; all other types
return $this. Composite types (UnionType, IntersectionType) delegate to
their members.

Co-authored-by: Markus Staab &lt;staabm@users.noreply.github.com&gt;
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -6366,13 +6366,8 @@ private function processAssignVar(
 				$declaringClass = $propertyReflection->getDeclaringClass();
 				if ($declaringClass->hasNativeProperty($propertyName)) {
 					$nativeProperty = $declaringClass->getNativeProperty($propertyName);
-					$propertyNativeType = $nativeProperty->getNativeType();
-					// Widen property type to accept int for float properties (PHP allows int-to-float coercion without TypeError)
-					$propertyNativeTypeForAccepts = !$propertyNativeType->isFloat()->no()
-						? TypeCombinator::union($propertyNativeType, new IntegerType())
-						: $propertyNativeType;
 					if (
-						!$propertyNativeTypeForAccepts->isSuperTypeOf($assignedExprType)->yes()
+						!$nativeProperty->getNativeType()->toCoercedPropertyType()->isSuperTypeOf($assignedExprType)->yes()
 					) {
 						$throwPoints[] = InternalThrowPoint::createExplicit($scope, new ObjectType(TypeError::class), $assignedExpr, false);
 					}
diff --git a/src/Type/Accessory/AccessoryArrayListType.php b/src/Type/Accessory/AccessoryArrayListType.php
@@ -484,6 +484,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function traverse(callable $cb): Type
 	{
 		return $this;
diff --git a/src/Type/Accessory/AccessoryLiteralStringType.php b/src/Type/Accessory/AccessoryLiteralStringType.php
@@ -228,6 +228,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isNull(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/Accessory/AccessoryLowercaseStringType.php b/src/Type/Accessory/AccessoryLowercaseStringType.php
@@ -225,6 +225,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isNull(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/Accessory/AccessoryNonEmptyStringType.php b/src/Type/Accessory/AccessoryNonEmptyStringType.php
@@ -225,6 +225,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isNull(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/Accessory/AccessoryNonFalsyStringType.php b/src/Type/Accessory/AccessoryNonFalsyStringType.php
@@ -228,6 +228,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isNull(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/Accessory/AccessoryNumericStringType.php b/src/Type/Accessory/AccessoryNumericStringType.php
@@ -233,6 +233,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isNull(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/Accessory/AccessoryUppercaseStringType.php b/src/Type/Accessory/AccessoryUppercaseStringType.php
@@ -225,6 +225,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isNull(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/Accessory/HasOffsetType.php b/src/Type/Accessory/HasOffsetType.php
@@ -405,6 +405,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function getEnumCases(): array
 	{
 		return [];
diff --git a/src/Type/Accessory/HasOffsetValueType.php b/src/Type/Accessory/HasOffsetValueType.php
@@ -472,6 +472,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function getEnumCases(): array
 	{
 		return [];
diff --git a/src/Type/Accessory/NonEmptyArrayType.php b/src/Type/Accessory/NonEmptyArrayType.php
@@ -469,6 +469,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function traverse(callable $cb): Type
 	{
 		return $this;
diff --git a/src/Type/Accessory/OversizedArrayType.php b/src/Type/Accessory/OversizedArrayType.php
@@ -447,6 +447,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function traverse(callable $cb): Type
 	{
 		return $this;
diff --git a/src/Type/BooleanType.php b/src/Type/BooleanType.php
@@ -119,6 +119,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isOffsetAccessLegal(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();
diff --git a/src/Type/CallableType.php b/src/Type/CallableType.php
@@ -441,6 +441,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		);
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function getTemplateTypeMap(): TemplateTypeMap
 	{
 		return $this->templateTypeMap;
diff --git a/src/Type/ClosureType.php b/src/Type/ClosureType.php
@@ -534,6 +534,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return TypeCombinator::union($this, new CallableType());
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function getTemplateTypeMap(): TemplateTypeMap
 	{
 		return $this->templateTypeMap;
diff --git a/src/Type/Constant/ConstantBooleanType.php b/src/Type/Constant/ConstantBooleanType.php
@@ -117,6 +117,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isTrue(): TrinaryLogic
 	{
 		return TrinaryLogic::createFromBoolean($this->value === true);
diff --git a/src/Type/Constant/ConstantIntegerType.php b/src/Type/Constant/ConstantIntegerType.php
@@ -102,6 +102,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return TypeCombinator::union($this, $this->toFloat());
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function generalize(GeneralizePrecision $precision): Type
 	{
 		return new IntegerType();
diff --git a/src/Type/FloatType.php b/src/Type/FloatType.php
@@ -151,6 +151,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return TypeCombinator::union($this, new IntegerType());
+	}
+
 	public function isOffsetAccessLegal(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();
diff --git a/src/Type/Generic/TemplateTypeTrait.php b/src/Type/Generic/TemplateTypeTrait.php
@@ -263,6 +263,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function inferTemplateTypes(Type $receivedType): TemplateTypeMap
 	{
 		if (
diff --git a/src/Type/IntegerType.php b/src/Type/IntegerType.php
@@ -106,6 +106,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return TypeCombinator::union($this, $this->toFloat());
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isOffsetAccessLegal(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();
diff --git a/src/Type/IntersectionType.php b/src/Type/IntersectionType.php
@@ -1292,6 +1292,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this->intersectTypes(static fn (Type $type): Type => $type->toCoercedArgumentType($strictTypes));
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this->intersectTypes(static fn (Type $type): Type => $type->toCoercedPropertyType());
+	}
+
 	public function inferTemplateTypes(Type $receivedType): TemplateTypeMap
 	{
 		$types = TemplateTypeMap::createEmpty();
diff --git a/src/Type/IterableType.php b/src/Type/IterableType.php
@@ -257,6 +257,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		);
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isIterable(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();
diff --git a/src/Type/MixedType.php b/src/Type/MixedType.php
@@ -636,6 +636,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isIterable(): TrinaryLogic
 	{
 		if ($this->subtractedType !== null) {
diff --git a/src/Type/NeverType.php b/src/Type/NeverType.php
@@ -429,6 +429,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function traverse(callable $cb): Type
 	{
 		return $this;
diff --git a/src/Type/NonexistentParentClassType.php b/src/Type/NonexistentParentClassType.php
@@ -193,6 +193,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return new ErrorType();
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isOffsetAccessLegal(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/NullType.php b/src/Type/NullType.php
@@ -179,6 +179,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isOffsetAccessible(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();
diff --git a/src/Type/ObjectType.php b/src/Type/ObjectType.php
@@ -905,6 +905,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function toBoolean(): BooleanType
 	{
 		if (
diff --git a/src/Type/ResourceType.php b/src/Type/ResourceType.php
@@ -95,6 +95,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isOffsetAccessLegal(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();
diff --git a/src/Type/StaticType.php b/src/Type/StaticType.php
@@ -745,6 +745,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this->getStaticObjectType()->toCoercedArgumentType($strictTypes);
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this->getStaticObjectType()->toCoercedPropertyType();
+	}
+
 	public function toBoolean(): BooleanType
 	{
 		return $this->getStaticObjectType()->toBoolean();
diff --git a/src/Type/StrictMixedType.php b/src/Type/StrictMixedType.php
@@ -431,6 +431,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function inferTemplateTypes(Type $receivedType): TemplateTypeMap
 	{
 		return TemplateTypeMap::createEmpty();
diff --git a/src/Type/StringType.php b/src/Type/StringType.php
@@ -192,6 +192,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isNull(): TrinaryLogic
 	{
 		return TrinaryLogic::createNo();
diff --git a/src/Type/Traits/ArrayTypeTrait.php b/src/Type/Traits/ArrayTypeTrait.php
@@ -35,6 +35,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this;
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this;
+	}
+
 	public function isOffsetAccessible(): TrinaryLogic
 	{
 		return TrinaryLogic::createYes();
diff --git a/src/Type/Traits/LateResolvableTypeTrait.php b/src/Type/Traits/LateResolvableTypeTrait.php
@@ -419,6 +419,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type
 		return $this->resolve()->toCoercedArgumentType($strictTypes);
 	}
 
+	public function toCoercedPropertyType(): Type
+	{
+		return $this->resolve()->toCoercedPropertyType();
+	}
+
 	public function isSmallerThan(Type $otherType, PhpVersion $phpVersion): TrinaryLogic
 	{
 		return $this->resolve()->isSmallerThan($otherType, $phpVersion);
diff --git a/src/Type/Traits/ObjectTypeTrait.php b/src/Type/Traits/ObjectTypeTrait.php
diff --git a/src/Type/Type.php b/src/Type/Type.php
diff --git a/src/Type/UnionType.php b/src/Type/UnionType.php
diff --git a/src/Type/VoidType.php b/src/Type/VoidType.php

Original file line number	Diff line number	Diff line change
`@@ -484,6 +484,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type`
`484`	`484`	`return $this;`
`485`	`485`	`}`
`486`	`486`
	`487`	`+ public function toCoercedPropertyType(): Type`
	`488`	`+ {`
	`489`	`+ return $this;`
	`490`	`+ }`
	`491`	`+`
`487`	`492`	`public function traverse(callable $cb): Type`
`488`	`493`	`{`
`489`	`494`	`return $this;`
Original file line number	Diff line number	Diff line change
`@@ -228,6 +228,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type`
`228`	`228`	`return $this;`
`229`	`229`	`}`
`230`	`230`
	`231`	`+ public function toCoercedPropertyType(): Type`
	`232`	`+ {`
	`233`	`+ return $this;`
	`234`	`+ }`
	`235`	`+`
`231`	`236`	`public function isNull(): TrinaryLogic`
`232`	`237`	`{`
`233`	`238`	`return TrinaryLogic::createNo();`
Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type`
`225`	`225`	`return $this;`
`226`	`226`	`}`
`227`	`227`
	`228`	`+ public function toCoercedPropertyType(): Type`
	`229`	`+ {`
	`230`	`+ return $this;`
	`231`	`+ }`
	`232`	`+`
`228`	`233`	`public function isNull(): TrinaryLogic`
`229`	`234`	`{`
`230`	`235`	`return TrinaryLogic::createNo();`
Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type`
`233`	`233`	`return $this;`
`234`	`234`	`}`
`235`	`235`
	`236`	`+ public function toCoercedPropertyType(): Type`
	`237`	`+ {`
	`238`	`+ return $this;`
	`239`	`+ }`
	`240`	`+`
`236`	`241`	`public function isNull(): TrinaryLogic`
`237`	`242`	`{`
`238`	`243`	`return TrinaryLogic::createNo();`
Original file line number	Diff line number	Diff line change
`@@ -405,6 +405,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type`
`405`	`405`	`return $this;`
`406`	`406`	`}`
`407`	`407`
	`408`	`+ public function toCoercedPropertyType(): Type`
	`409`	`+ {`
	`410`	`+ return $this;`
	`411`	`+ }`
	`412`	`+`
`408`	`413`	`public function getEnumCases(): array`
`409`	`414`	`{`
`410`	`415`	`return [];`
Original file line number	Diff line number	Diff line change
`@@ -472,6 +472,11 @@ public function toCoercedArgumentType(bool $strictTypes): Type`
`472`	`472`	`return $this;`
`473`	`473`	`}`
`474`	`474`
	`475`	`+ public function toCoercedPropertyType(): Type`
	`476`	`+ {`
	`477`	`+ return $this;`
	`478`	`+ }`
	`479`	`+`
`475`	`480`	`public function getEnumCases(): array`
`476`	`481`	`{`
`477`	`482`	`return [];`