-
Notifications
You must be signed in to change notification settings - Fork 4
Open
gamedaoco/gamedao-protocol
#115Description
What needs to be done
Update code to fix issues, noted during Milestone 2 code review from Parity team.
Why it needs to be done
Increase code quality, follow best practices and high standards of the industry.
Acceptance Criteria/Task List
Fix next code issues
Control
- for genesis build block number should be known [source]
-
newfunction fortypes::Org[source] - print some logs if sth goes wrong while genesis build [source]
- use
is_someto check for set values [source] - update
pay_membership_feemethod to acceptorgand use it's fields [source] - replace
unwrapwith error handling [source] - move event creating from helper to extrinsic [source]
- move event creating from helper to extrinsic [source]
- move benchmarking trait to benchmarks module [source]
Flow
- cleanup storage if campaign doesn't exist [souce]
- replace
unwrapwith error handling [source] - replace
if, else ifwith match clause [source] - replace
if, else ifwith match clause [source] - move benchmarking trait to benchmarks module [source]
Sense
- replace
unwrapwith error handling [source]
Signal
- replace
unwrapwith error handling [source] - replace
unwrapwith error handling [source] - replace
unwrapwith error handling [source] - ensure proposal finalization properly handled [source]
- replace
unwrapwith error handling [source] - proper error handling for currency call [source]
- proper error handling for currency call [source]
- self-explanatory tests names [source]