Installer always requests admin execution level

[SnejPro]

Describe the bug
When installing on windows, the installer always requests admin execution level, but the default installation location is in the Users Folder.

To Reproduce
Try installing on Windows.

Expected behavior
As the installer tries to install in the users folder, it should not request admin execution level:

https://nsis.sourceforge.io/Reference/RequestExecutionLevel

Desktop (please complete the following information):

• OS: Windows
• Version 0.80.3

[arnonm]

The installer asks for Admin rights due to the installer's use of the HKLM registry hive to register the uninstaller, specifically in the main installation section:
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall$APPNAMEFULL" "DisplayName" "$APPNAMEFULL"
; ... and all subsequent WriteRegStr/WriteRegDWORD commands ...
Writing to this location is the standard way to register an application to appear in the "Add or Remove Programs" list for all users, but it triggers the User Account Control (UAC) prompt for elevation.

To avoid this prompt, the following changes would be needed:
Replace every instance of HKLM in the Section and Section "Uninstall" blocks with HKCU:
; In the main Section:
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall$APPNAMEFULL" "DisplayName" "$APPNAMEFULL"
; ... all other WriteRegStr/WriteRegDWORD lines

; In the Uninstall Section:
DeleteRegKey HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall${APPNAME}"

also remove the explicit use of the AccessControl::GrantOnFile plugin line, as this may also sometimes trigger UAC, although it's not the primary reason in this case
Since the installation directory is $LOCALAPPDATA\Programs, the user already has full permissions to that folder, making this explicit call redundant and potentially problematic

We could also give the user the option to install for All Users (Admin required) or Current User (No Admin required)- need feedback if this is desired.

[Morpheus1w3]

portfolio/portfolio-product/installer/installer.nsi

Lines 69 to 80 in 6f4d7aa

	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayName" "$APPNAMEFULL"
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "UninstallString" "$\"$INSTDIR\uninstall.exe$\""
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "QuietUninstallString" "$\"$INSTDIR\uninstall.exe$\" /S"
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "InstallLocation" "$\"$INSTDIR$\""
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayIcon" "$\"$INSTDIR\${APPEXE}$\""
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayVersion" "${SOFTWARE_VERSION}"
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "Publisher" "${PUBLISHER}"
	# there is no option for modifying or repairing the install
	WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoModify" 1
	WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoRepair" 1
	# set the INSTALLSIZE constant (!defined at the top of this script) so Add/Remove Programs can accurately report the size
	WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "EstimatedSize" ${INSTALLSIZE}

portfolio/portfolio-product/installer/installer.nsi

Line 96 in 6f4d7aa

DeleteRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"

[SnejPro]

portfolio/portfolio-product/installer/installer.nsi

Lines 69 to 80 in 6f4d7aa

	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayName" "$APPNAMEFULL"
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "UninstallString" "$\"$INSTDIR\uninstall.exe$\""
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "QuietUninstallString" "$\"$INSTDIR\uninstall.exe$\" /S"
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "InstallLocation" "$\"$INSTDIR$\""
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayIcon" "$\"$INSTDIR\${APPEXE}$\""
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayVersion" "${SOFTWARE_VERSION}"
	WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "Publisher" "${PUBLISHER}"
	# there is no option for modifying or repairing the install
	WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoModify" 1
	WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoRepair" 1
	# set the INSTALLSIZE constant (!defined at the top of this script) so Add/Remove Programs can accurately report the size
	WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "EstimatedSize" ${INSTALLSIZE}

portfolio/portfolio-product/installer/installer.nsi

Line 96 in 6f4d7aa

DeleteRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"

Nice 👍 Thank you
Will it still be possible to install for all users if the HKCU registry keys are used?

[arnonm]

For that we would need to add a dialog box and ask the user where he wants to install. Doable - will do a PR

…

On Sat, Dec 27, 2025 at 3:51 PM Jens ***@***.***> wrote: *SnejPro* left a comment (portfolio-performance/portfolio#5092) <#5092 (comment)> https://github.com/portfolio-performance/portfolio/blob/6f4d7aa8100c887df4e8f51ac292565daa34e7af/portfolio-product/installer/installer.nsi#L69-L80 https://github.com/portfolio-performance/portfolio/blob/6f4d7aa8100c887df4e8f51ac292565daa34e7af/portfolio-product/installer/installer.nsi#L96 Nice 👍 Thank you Will it still be possible to install for all users if the HKCU registry keys are used? — Reply to this email directly, view it on GitHub <#5092 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5BWKKWRTZIUMEELHHGIYD4D2FFLAVCNFSM6AAAAACJVVQCMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJTHE4TAMBQG4> . You are receiving this because you commented.Message ID: ***@***.***>

[SnejPro]

For that we would need to add a dialog box and ask the user where he wants
to install. Doable - will do a PR

A command line argument to toggle user/machine-wide installation would be great as well. E.g. for using winget.