diff --git a/src/main/java/org/prebid/server/bidder/nativo/NativoBidder.java b/src/main/java/org/prebid/server/bidder/nativo/NativoBidder.java new file mode 100644 index 00000000000..444cd2e0352 --- /dev/null +++ b/src/main/java/org/prebid/server/bidder/nativo/NativoBidder.java @@ -0,0 +1,155 @@ +package org.prebid.server.bidder.nativo; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.apache.commons.collections4.CollectionUtils; +import org.prebid.server.bidder.Bidder; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.exception.PreBidException; +import org.prebid.server.json.DecodeException; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtRequest; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidSdk; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidSdkRenderer; +import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid; +import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidMeta; +import org.prebid.server.util.BidderUtil; +import org.prebid.server.util.HttpUtil; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.function.Function; +import java.util.stream.Collectors; + +public class NativoBidder implements Bidder { + + private static final String NATIVO_RENDERER_NAME = "NativoRenderer"; + private static final String PREBID_EXT = "prebid"; + private static final TypeReference> EXT_PREBID_TYPE_REFERENCE = + new TypeReference<>() { + }; + + private final String endpointUrl; + private final JacksonMapper mapper; + + public NativoBidder(String endpointUrl, JacksonMapper mapper) { + this.endpointUrl = HttpUtil.validateUrlSyntax(Objects.requireNonNull(endpointUrl)); + this.mapper = Objects.requireNonNull(mapper); + } + + @Override + public final Result>> makeHttpRequests(BidRequest bidRequest) { + return Result.withValue(BidderUtil.defaultRequest(bidRequest, endpointUrl, mapper)); + } + + @Override + public final Result> makeBids(BidderCall httpCall, BidRequest bidRequest) { + try { + final List errors = new ArrayList<>(); + final BidResponse bidResponse = mapper.decodeValue(httpCall.getResponse().getBody(), BidResponse.class); + return Result.of(extractBids(httpCall.getRequest().getPayload(), bidResponse, errors), errors); + } catch (DecodeException e) { + return Result.withError(BidderError.badServerResponse(e.getMessage())); + } + } + + private List extractBids(BidRequest bidRequest, BidResponse bidResponse, List errors) { + if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) { + return Collections.emptyList(); + } + return bidsFromResponse(bidRequest, bidResponse, errors); + } + + private List bidsFromResponse(BidRequest bidRequest, BidResponse bidResponse, List errors) { + final Map impMap = bidRequest.getImp().stream() + .collect(Collectors.toMap(Imp::getId, Function.identity())); + final String rendererVersion = getNativoRendererVersion(bidRequest); + + return bidResponse.getSeatbid().stream() + .filter(Objects::nonNull) + .map(SeatBid::getBid) + .filter(Objects::nonNull) + .flatMap(Collection::stream) + .filter(Objects::nonNull) + .map(bid -> updateBid(bid, rendererVersion, errors)) + .map(bid -> BidderBid.of(bid, BidderUtil.getBidType(bid, impMap), bidResponse.getCur())) + .toList(); + } + + private String getNativoRendererVersion(BidRequest bidRequest) { + return Optional.ofNullable(bidRequest.getExt()) + .map(ExtRequest::getPrebid) + .map(ExtRequestPrebid::getSdk) + .map(ExtRequestPrebidSdk::getRenderers) + .orElse(Collections.emptyList()) + .stream() + .filter(renderer -> NATIVO_RENDERER_NAME.equals(renderer.getName())) + .map(ExtRequestPrebidSdkRenderer::getVersion) + .findFirst() + .orElse(null); + } + + private Bid updateBid(Bid bid, String rendererVersion, List errors) { + if (rendererVersion == null) { + return bid; + } + + final ObjectNode updateBidExt; + try { + updateBidExt = updateBidExt(bid, rendererVersion); + } catch (PreBidException e) { + errors.add(BidderError.badServerResponse(e.getMessage())); + return bid; + } + + return bid.toBuilder().ext(updateBidExt).build(); + } + + private ObjectNode updateBidExt(Bid bid, String rendererVersion) { + final ObjectNode bidExt = bid.getExt(); + final Optional extBidPrebid = Optional.ofNullable(bidExt) + .map(ext -> parseExtBidPrebid(bidExt, bid.getId())); + + final ExtBidPrebidMeta updatedMeta = extBidPrebid + .map(ExtBidPrebid::getMeta) + .map(ExtBidPrebidMeta::toBuilder) + .orElseGet(ExtBidPrebidMeta::builder) + .rendererVersion(rendererVersion) + .build(); + + final ExtBidPrebid modifiedExtBidPrebid = extBidPrebid + .map(ExtBidPrebid::toBuilder) + .orElseGet(ExtBidPrebid::builder) + .meta(updatedMeta) + .build(); + + final ObjectNode updatedBidExt = bidExt != null ? bidExt : mapper.mapper().createObjectNode(); + updatedBidExt.set(PREBID_EXT, mapper.mapper().valueToTree(modifiedExtBidPrebid)); + return updatedBidExt; + } + + private ExtBidPrebid parseExtBidPrebid(ObjectNode bidExt, String bidId) { + try { + return mapper.mapper().convertValue(bidExt, EXT_PREBID_TYPE_REFERENCE).getPrebid(); + } catch (IllegalArgumentException e) { + throw new PreBidException("Invalid ext passed in bid with id: " + bidId); + } + } + +} diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativo/ExtImpNativo.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativo/ExtImpNativo.java new file mode 100644 index 00000000000..8dfb32333d7 --- /dev/null +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativo/ExtImpNativo.java @@ -0,0 +1,11 @@ +package org.prebid.server.proto.openrtb.ext.request.nativo; + +import com.fasterxml.jackson.annotation.JsonProperty; +import lombok.Value; + +@Value(staticConstructor = "of") +public class ExtImpNativo { + + @JsonProperty("placementId") + Object placementId; +} diff --git a/src/main/java/org/prebid/server/spring/config/bidder/NativoConfiguration.java b/src/main/java/org/prebid/server/spring/config/bidder/NativoConfiguration.java new file mode 100644 index 00000000000..52cb32090db --- /dev/null +++ b/src/main/java/org/prebid/server/spring/config/bidder/NativoConfiguration.java @@ -0,0 +1,41 @@ +package org.prebid.server.spring.config.bidder; + +import org.prebid.server.bidder.BidderDeps; +import org.prebid.server.bidder.nativo.NativoBidder; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties; +import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler; +import org.prebid.server.spring.config.bidder.util.UsersyncerCreator; +import org.prebid.server.spring.env.YamlPropertySourceFactory; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.context.annotation.PropertySource; + +import jakarta.validation.constraints.NotBlank; + +@Configuration +@PropertySource(value = "classpath:/bidder-config/nativo.yaml", factory = YamlPropertySourceFactory.class) +public class NativoConfiguration { + + private static final String BIDDER_NAME = "nativo"; + + @Bean("nativoConfigurationProperties") + @ConfigurationProperties("adapters.nativo") + BidderConfigurationProperties configurationProperties() { + return new BidderConfigurationProperties(); + } + + @Bean + BidderDeps nativoBidderDeps(BidderConfigurationProperties nativoConfigurationProperties, + @NotBlank @Value("${external-url}") String externalUrl, + JacksonMapper mapper) { + + return BidderDepsAssembler.forBidder(BIDDER_NAME) + .withConfig(nativoConfigurationProperties) + .usersyncerCreator(UsersyncerCreator.create(externalUrl)) + .bidderCreator(config -> new NativoBidder(config.getEndpoint(), mapper)) + .assemble(); + } +} diff --git a/src/main/resources/bidder-config/generic.yaml b/src/main/resources/bidder-config/generic.yaml index d4538733e05..d10f45c9406 100644 --- a/src/main/resources/bidder-config/generic.yaml +++ b/src/main/resources/bidder-config/generic.yaml @@ -115,28 +115,6 @@ adapters: url: https://sync.adsinteractive.com/getuid?{{redirect_url}}&gpp={{gpp}}&gpp_sid={{gpp_sid}} support-cors: false uid-macro: '$AUID' - nativo: - enabled: false - endpoint: https://exchange.postrelease.com/esi?ntv_epid=7 - pbs-enforces-ccpa: false - meta-info: - maintainer-email: prebiddev@nativo.com - app-media-types: - - banner - - video - - native - site-media-types: - - banner - - video - - native - supported-vendors: - vendor-id: 263 - usersync: - cookie-family-name: nativo - redirect: - url: https://jadserve.postrelease.com/suid/101787?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&ntv_gpp_consent={{gpp}}&ntv_r={{redirect_url}} - support-cors: false - uid-macro: 'NTV_USER_ID' meta-info: maintainer-email: maintainer@example.com app-media-types: diff --git a/src/main/resources/bidder-config/nativo.yaml b/src/main/resources/bidder-config/nativo.yaml new file mode 100644 index 00000000000..8af47bc6ebd --- /dev/null +++ b/src/main/resources/bidder-config/nativo.yaml @@ -0,0 +1,23 @@ +adapters: + nativo: + endpoint: https://exchange.postrelease.com/esi?ntv_epid=7 + ortb-version: "2.6" + pbs-enforces-ccpa: false + meta-info: + maintainer-email: prebiddev@nativo.com + app-media-types: + - banner + - video + - native + site-media-types: + - banner + - video + - native + supported-vendors: + vendor-id: 263 + usersync: + cookie-family-name: nativo + redirect: + url: https://jadserve.postrelease.com/suid/101787?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&ntv_gpp_consent={{gpp}}&ntv_r={{redirect_url}} + support-cors: false + uid-macro: 'NTV_USER_ID' diff --git a/src/main/resources/static/bidder-params/nativo.json b/src/main/resources/static/bidder-params/nativo.json new file mode 100644 index 00000000000..d25ec75f3bc --- /dev/null +++ b/src/main/resources/static/bidder-params/nativo.json @@ -0,0 +1,12 @@ +{ + "$schema": "http://json-schema.org/draft-04/schema#", + "title": "Nativo Adapter Params", + "description": "A schema which validates params accepted by the Nativo adapter", + "type": "object", + "properties": { + "placementId": { + "type": ["integer", "string"], + "description": "Placement ID" + } + } +} diff --git a/src/test/groovy/org/prebid/server/functional/testcontainers/PbsConfig.groovy b/src/test/groovy/org/prebid/server/functional/testcontainers/PbsConfig.groovy index 02d627f141a..6e02adf0a5e 100644 --- a/src/test/groovy/org/prebid/server/functional/testcontainers/PbsConfig.groovy +++ b/src/test/groovy/org/prebid/server/functional/testcontainers/PbsConfig.groovy @@ -125,8 +125,6 @@ LIMIT 1 "adapters.generic.aliases.blue.meta-info.site-media-types" : "", "adapters.generic.aliases.adsinteractive.meta-info.app-media-types" : "", "adapters.generic.aliases.adsinteractive.meta-info.site-media-types" : "", - "adapters.generic.aliases.nativo.meta-info.app-media-types" : "", - "adapters.generic.aliases.nativo.meta-info.site-media-types" : "", "adapters.generic.aliases.infytv.meta-info.app-media-types" : "", "adapters.generic.aliases.infytv.meta-info.site-media-types" : "", "adapters.generic.aliases.zeta-global-ssp.meta-info.app-media-types" : "", diff --git a/src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy b/src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy index 220585f008f..81b2dc5d46e 100644 --- a/src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy +++ b/src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy @@ -1348,8 +1348,8 @@ class BidderParamsSpec extends BaseSpec { def bidRequest = BidRequest.defaultBidRequest.tap { imp[0].ext.prebid.bidder.tap { it.generic.exampleProperty = PBSUtils.randomNumber - //Nativo hard coded bidder alias in generic.yaml - it.nativo = new Generic(exampleProperty: PBSUtils.randomNumber) + //Adrino hard coded bidder alias in generic.yaml + it.adrino = new Adrino(hash: PBSUtils.randomNumber) } } @@ -1362,9 +1362,9 @@ class BidderParamsSpec extends BaseSpec { ["WARNING: request.imp[0].ext.prebid.bidder.generic was dropped with a reason: " + "request.imp[0].ext.prebid.bidder.generic failed validation.\n" + "\$.exampleProperty: integer found, string expected", - "WARNING: request.imp[0].ext.prebid.bidder.nativo was dropped with a reason: " + - "request.imp[0].ext.prebid.bidder.nativo failed validation.\n" + - "\$.exampleProperty: integer found, string expected", + "WARNING: request.imp[0].ext.prebid.bidder.adrino was dropped with a reason: " + + "request.imp[0].ext.prebid.bidder.adrino failed validation.\n" + + "\$.hash: integer found, string expected", "WARNING: request.imp[0].ext must contain at least one valid bidder"] and: "PBS should not call bidder" diff --git a/src/test/java/org/prebid/server/bidder/nativo/NativoBidderTest.java b/src/test/java/org/prebid/server/bidder/nativo/NativoBidderTest.java new file mode 100644 index 00000000000..18dda0deeba --- /dev/null +++ b/src/test/java/org/prebid/server/bidder/nativo/NativoBidderTest.java @@ -0,0 +1,307 @@ +package org.prebid.server.bidder.nativo; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.Banner; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.request.Native; +import com.iab.openrtb.request.Video; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.junit.jupiter.api.Test; +import org.prebid.server.VertxTest; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.HttpResponse; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.proto.openrtb.ext.request.ExtRequest; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidSdk; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidSdkRenderer; +import org.prebid.server.proto.openrtb.ext.response.BidType; + +import java.math.BigDecimal; +import java.util.List; +import java.util.function.UnaryOperator; + +import static java.util.Collections.singletonList; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; + +public class NativoBidderTest extends VertxTest { + + private static final String ENDPOINT_URL = "https://test.endpoint.com/"; + + private final NativoBidder target = new NativoBidder(ENDPOINT_URL, jacksonMapper); + + @Test + public void creationShouldFailOnInvalidEndpointUrl() { + assertThatIllegalArgumentException().isThrownBy(() -> new NativoBidder("invalid_url", jacksonMapper)); + } + + @Test + public void makeHttpRequestsShouldReturnSingleDefaultRequest() { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.banner(Banner.builder().build())); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + assertThat(result.getValue().get(0).getPayload()).isEqualTo(bidRequest); + } + + @Test + public void makeBidsShouldReturnErrorWhenResponseBodyCouldNotBeParsed() { + // given + final BidderCall httpCall = BidderCall.succeededHttp( + HttpRequest.builder().build(), + HttpResponse.of(200, null, "invalid_json"), + null); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response); + assertThat(error.getMessage()).startsWith("Failed to decode: Unrecognized token 'invalid_json'"); + }); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnEmptyListWhenBidResponseHasNullSeatbid() throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.id("imp1").banner(Banner.builder().build())); + final BidResponse bidResponse = BidResponse.builder().id("resp1").build(); + final BidderCall httpCall = givenHttpCall(bidRequest, bidResponse); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnEmptyListWhenBidResponseHasEmptySeatbid() throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.id("imp1").banner(Banner.builder().build())); + final BidResponse bidResponse = BidResponse.builder().id("resp1").seatbid(List.of()).build(); + final BidderCall httpCall = givenHttpCall(bidRequest, bidResponse); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnBannerBidWhenNoNativoRendererInRequest() throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.id("imp1").banner(Banner.builder().build())); + final Bid bid = givenBid("bid1", "imp1"); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(bid, BidType.banner, "USD")); + } + + @Test + public void makeBidsShouldReturnVideoBidWhenNoNativoRendererInRequest() throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.id("imp1").video(Video.builder().build())); + final Bid bid = givenBid("bid1", "imp1"); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(bid, BidType.video, "USD")); + } + + @Test + public void makeBidsShouldReturnNativeBidWhenNoNativoRendererInRequest() throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.id("imp1").xNative(Native.builder().build())); + final Bid bid = givenBid("bid1", "imp1"); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(bid, BidType.xNative, "USD")); + } + + @Test + public void makeBidsShouldNotModifyBidWhenRendererNameDoesNotMatchNativo() throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequestWithRenderer( + imp -> imp.id("imp1").banner(Banner.builder().build()), + "OtherRenderer", "1.0.0"); + final Bid bid = givenBid("bid1", "imp1"); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(bid, BidType.banner, "USD")); + } + + @Test + public void makeBidsShouldEnrichBidExtWithRendererVersionWhenNativoRendererIsPresent() + throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequestWithRenderer( + imp -> imp.id("imp1").banner(Banner.builder().build()), + "NativoRenderer", "1.2.3"); + final Bid bid = givenBid("bid1", "imp1"); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + assertThat(result.getValue().get(0).getBid().getExt()) + .extracting(ext -> ext.get("prebid")) + .extracting(prebid -> prebid.get("meta")) + .extracting(meta -> meta.get("rendererVersion").textValue()) + .isEqualTo("1.2.3"); + } + + @Test + public void makeBidsShouldPreserveExistingMetaFieldsWhenAddingRendererVersion() + throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequestWithRenderer( + imp -> imp.id("imp1").banner(Banner.builder().build()), + "NativoRenderer", "2.0.0"); + + final ObjectNode existingExt = mapper.createObjectNode(); + existingExt.putObject("prebid").putObject("meta").put("adaptercode", "nativo"); + final Bid bid = givenBid("bid1", "imp1").toBuilder().ext(existingExt).build(); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final ObjectNode resultExt = result.getValue().get(0).getBid().getExt(); + assertThat(resultExt.get("prebid").get("meta").get("adaptercode").textValue()).isEqualTo("nativo"); + assertThat(resultExt.get("prebid").get("meta").get("rendererVersion").textValue()).isEqualTo("2.0.0"); + } + + @Test + public void makeBidsShouldCreateMetaWhenBidExtHasNoPrebidFieldAndNativoRendererIsPresent() + throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequestWithRenderer( + imp -> imp.id("imp1").banner(Banner.builder().build()), + "NativoRenderer", "3.0.0"); + final Bid bid = givenBid("bid1", "imp1"); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final ObjectNode resultExt = result.getValue().get(0).getBid().getExt(); + assertThat(resultExt.get("prebid").get("meta").get("rendererVersion").textValue()).isEqualTo("3.0.0"); + } + + @Test + public void makeBidsShouldReturnErrorAndOriginalBidWhenBidExtCannotBeParsed() + throws JsonProcessingException { + // given + final BidRequest bidRequest = givenBidRequestWithRenderer( + imp -> imp.id("imp1").banner(Banner.builder().build()), + "NativoRenderer", "1.0.0"); + + final ObjectNode invalidExt = mapper.createObjectNode(); + invalidExt.put("prebid", "not-an-object"); + final Bid bid = givenBid("bid1", "imp1").toBuilder().ext(invalidExt).build(); + final BidderCall httpCall = givenHttpCall(bidRequest, givenBidResponse(singletonList(bid))); + + // when + final Result> result = target.makeBids(httpCall, bidRequest); + + // then + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response); + assertThat(error.getMessage()).contains("Invalid ext passed in bid with id: bid1"); + }); + assertThat(result.getValue()).hasSize(1); + assertThat(result.getValue().get(0).getBid().getExt()).isEqualTo(invalidExt); + } + + private static BidRequest givenBidRequest(UnaryOperator impCustomizer) { + return BidRequest.builder() + .imp(singletonList(impCustomizer.apply(Imp.builder().id("imp1")).build())) + .build(); + } + + private static BidRequest givenBidRequestWithRenderer(UnaryOperator impCustomizer, + String rendererName, String rendererVersion) { + return BidRequest.builder() + .imp(singletonList(impCustomizer.apply(Imp.builder().id("imp1")).build())) + .ext(ExtRequest.of(ExtRequestPrebid.builder() + .sdk(ExtRequestPrebidSdk.of(singletonList( + ExtRequestPrebidSdkRenderer.of(rendererName, rendererVersion, null, null)))) + .build())) + .build(); + } + + private static Bid givenBid(String id, String impId) { + return Bid.builder() + .id(id) + .impid(impId) + .price(BigDecimal.valueOf(1.5)) + .adm("adm001") + .build(); + } + + private static BidResponse givenBidResponse(List bids) { + return BidResponse.builder() + .cur("USD") + .seatbid(singletonList(SeatBid.builder().bid(bids).build())) + .build(); + } + + private BidderCall givenHttpCall(BidRequest bidRequest, BidResponse bidResponse) + throws JsonProcessingException { + return BidderCall.succeededHttp( + HttpRequest.builder().payload(bidRequest).build(), + HttpResponse.of(200, null, mapper.writeValueAsString(bidResponse)), + null); + } +} diff --git a/src/test/java/org/prebid/server/it/NativoTest.java b/src/test/java/org/prebid/server/it/NativoTest.java new file mode 100644 index 00000000000..f8d1cf086ee --- /dev/null +++ b/src/test/java/org/prebid/server/it/NativoTest.java @@ -0,0 +1,35 @@ +package org.prebid.server.it; + +import io.restassured.response.Response; +import org.json.JSONException; +import org.junit.jupiter.api.Test; +import org.prebid.server.model.Endpoint; + +import java.io.IOException; + +import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; +import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; +import static com.github.tomakehurst.wiremock.client.WireMock.post; +import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; +import static java.util.Collections.singletonList; + +public class NativoTest extends IntegrationTest { + + @Test + public void openrtb2AuctionShouldRespondWithBidsFromNativo() throws IOException, JSONException { + // given + WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/nativo-exchange")) + .withRequestBody(equalToJson( + jsonFrom("openrtb2/nativo/test-nativo-bid-request.json"))) + .willReturn(aResponse().withBody( + jsonFrom("openrtb2/nativo/test-nativo-bid-response.json")))); + + // when + final Response response = responseFor("openrtb2/nativo/test-auction-nativo-request.json", + Endpoint.openrtb2_auction); + + // then + assertJsonEquals("openrtb2/nativo/test-auction-nativo-response.json", response, + singletonList("nativo")); + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-auction-nativo-request.json b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-auction-nativo-request.json new file mode 100644 index 00000000000..1cd8abe5f07 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-auction-nativo-request.json @@ -0,0 +1,46 @@ +{ + "id": "tid", + "imp": [ + { + "id": "impId001", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + } + ] + }, + "ext": { + "nativo": { + "placementId": 12345678 + } + } + } + ], + "device": { + "pxratio": 4.2, + "dnt": 2, + "language": "en", + "ifa": "ifaId" + }, + "site": { + "publisher": { + "id": "publisherId" + } + }, + "at": 1, + "tmax": 5000, + "cur": [ + "USD" + ], + "source": { + "fd": 1, + "tid": "tid" + }, + "regs": { + "ext": { + "gdpr": 0 + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-auction-nativo-response.json b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-auction-nativo-response.json new file mode 100644 index 00000000000..e744d31c4f7 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-auction-nativo-response.json @@ -0,0 +1,42 @@ +{ + "id": "tid", + "seatbid": [ + { + "bid": [ + { + "id": "bid001", + "impid": "impId001", + "exp": 300, + "price": 3.33, + "adm": "adm001", + "adid": "adid001", + "cid": "cid001", + "crid": "crid001", + "w": 300, + "h": 250, + "ext": { + "prebid": { + "type": "banner", + "meta": { + "adaptercode": "nativo" + } + }, + "origbidcpm": 3.33 + } + } + ], + "seat": "nativo", + "group": 0 + } + ], + "cur": "USD", + "ext": { + "responsetimemillis": { + "nativo": "{{ nativo.response_time_ms }}" + }, + "prebid": { + "auctiontimestamp": 1000 + }, + "tmaxrequest": 5000 + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-nativo-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-nativo-bid-request.json new file mode 100644 index 00000000000..595682efc23 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-nativo-bid-request.json @@ -0,0 +1,69 @@ +{ + "id": "tid", + "imp": [ + { + "id": "impId001", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + } + ] + }, + "secure": 1, + "ext": { + "tid": "${json-unit.any-string}", + "bidder": { + "placementId": 12345678 + } + } + } + ], + "site": { + "domain": "www.example.com", + "page": "http://www.example.com", + "publisher": { + "id": "publisherId", + "domain": "example.com" + }, + "ext": { + "amp": 0 + } + }, + "device": { + "dnt": 2, + "ua": "userAgent", + "ip": "193.168.244.1", + "pxratio": 4.2, + "language": "en", + "ifa": "ifaId" + }, + "at": 1, + "tmax": "${json-unit.any-number}", + "cur": [ + "USD" + ], + "source": { + "fd": 1, + "tid": "tid" + }, + "regs": { + "ext": { + "gdpr": 0 + } + }, + "ext": { + "prebid": { + "channel": { + "name": "web" + }, + "server": { + "externalurl": "http://localhost:8080", + "gvlid": 1, + "datacenter": "local", + "endpoint": "/openrtb2/auction" + } + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-nativo-bid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-nativo-bid-response.json new file mode 100644 index 00000000000..c31fabcb822 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativo/test-nativo-bid-response.json @@ -0,0 +1,20 @@ +{ + "id": "tid", + "seatbid": [ + { + "bid": [ + { + "id": "bid001", + "impid": "impId001", + "price": 3.33, + "adid": "adid001", + "crid": "crid001", + "cid": "cid001", + "adm": "adm001", + "h": 250, + "w": 300 + } + ] + } + ] +} diff --git a/src/test/resources/org/prebid/server/it/test-application.properties b/src/test/resources/org/prebid/server/it/test-application.properties index 8bbbef8c2e4..1ed06f4c82b 100644 --- a/src/test/resources/org/prebid/server/it/test-application.properties +++ b/src/test/resources/org/prebid/server/it/test-application.properties @@ -2,8 +2,6 @@ adapters.generic.enabled=true adapters.generic.endpoint=http://localhost:8090/generic-exchange adapters.generic.aliases.genericAlias.enabled=true adapters.generic.aliases.genericAlias.endpoint=http://localhost:8090/genericAlias-exchange -adapters.generic.aliases.nativo.enabled=true -adapters.generic.aliases.nativo.endpoint=http://localhost:8090/nativo-exchange adapters.generic.aliases.adrino.enabled=true adapters.generic.aliases.adrino.endpoint=http://localhost:8090/adrino-exchange adapters.generic.aliases.blue.enabled=true @@ -406,6 +404,8 @@ adapters.motorik.enabled=true adapters.motorik.endpoint=http://localhost:8090/motorik-exchange?k={{AccountID}}&name={{SourceId}} adapters.nativery.enabled=true adapters.nativery.endpoint=http://localhost:8090/nativery-exchange +adapters.nativo.enabled=true +adapters.nativo.endpoint=http://localhost:8090/nativo-exchange adapters.nextmillennium.enabled=true adapters.nextmillennium.endpoint=http://localhost:8090/nextmillennium-exchange adapters.nextmillennium.extra-info.nmmFlags=1