From 483e310dc34d1787006437a7468616dba9269e06 Mon Sep 17 00:00:00 2001 From: bsardo <1168933+bsardo@users.noreply.github.com> Date: Mon, 9 Feb 2026 23:32:44 -0500 Subject: [PATCH 1/2] Fix: Require explicit GVL vendor ID declaration for aliases --- config/bidderinfo.go | 3 --- config/bidderinfo_test.go | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/config/bidderinfo.go b/config/bidderinfo.go index d3873bf2e94..06a5cd12d7c 100644 --- a/config/bidderinfo.go +++ b/config/bidderinfo.go @@ -391,9 +391,6 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi if aliasBidderInfo.ExtraAdapterInfo == "" { aliasBidderInfo.ExtraAdapterInfo = parentBidderInfo.ExtraAdapterInfo } - if aliasBidderInfo.GVLVendorID == 0 { - aliasBidderInfo.GVLVendorID = parentBidderInfo.GVLVendorID - } if aliasBidderInfo.Maintainer == nil { aliasBidderInfo.Maintainer = parentBidderInfo.Maintainer } diff --git a/config/bidderinfo_test.go b/config/bidderinfo_test.go index 8c251842c71..725eaf89b85 100644 --- a/config/bidderinfo_test.go +++ b/config/bidderinfo_test.go @@ -255,7 +255,7 @@ func TestProcessBidderInfo(t *testing.T) { }, }, ExtraAdapterInfo: "extra-info", - GVLVendorID: 42, + GVLVendorID: 0, Maintainer: &MaintainerInfo{ Email: "some-email@domain.com", }, @@ -392,6 +392,7 @@ func TestProcessAliasBidderInfo(t *testing.T) { } bidderB := parentWithSyncerKey bidderB.AliasOf = "bidderA" + bidderB.GVLVendorID = 0 bidderB.Syncer = &Syncer{ Key: bidderB.Syncer.Key, } From 32e8b30cb3f5a8fd0970aed607d015a4b22392d7 Mon Sep 17 00:00:00 2001 From: bsardo <1168933+bsardo@users.noreply.github.com> Date: Mon, 9 Feb 2026 23:35:45 -0500 Subject: [PATCH 2/2] Explicitly declare same GVL ID for aliases as parent when it is clear the GVL entry represents them --- static/bidder-info/admaticde.yaml | 3 ++- static/bidder-info/epsilon.yaml | 1 + static/bidder-info/equativ.yaml | 1 + static/bidder-info/freewheel-ssp.yaml | 1 + static/bidder-info/magnite.yaml | 3 ++- static/bidder-info/showheroes-bs.yaml | 3 ++- static/bidder-info/showheroesBs.yaml | 3 ++- static/bidder-info/ttd.yaml | 1 + static/bidder-info/yahooAdvertising.yaml | 1 + static/bidder-info/yahoossp.yaml | 1 + 10 files changed, 14 insertions(+), 4 deletions(-) diff --git a/static/bidder-info/admaticde.yaml b/static/bidder-info/admaticde.yaml index 562aa183695..fdd9b6107d6 100644 --- a/static/bidder-info/admaticde.yaml +++ b/static/bidder-info/admaticde.yaml @@ -1 +1,2 @@ -aliasOf: "admatic" \ No newline at end of file +aliasOf: "admatic" +gvlVendorID: 1281 \ No newline at end of file diff --git a/static/bidder-info/epsilon.yaml b/static/bidder-info/epsilon.yaml index cb8318102e8..4da155b06f1 100644 --- a/static/bidder-info/epsilon.yaml +++ b/static/bidder-info/epsilon.yaml @@ -1,4 +1,5 @@ aliasOf: conversant +gvlVendorID: 24 userSync: redirect: url: "https://prebid-match.dotomi.com/match/bounce/current?version=1&networkId=72582&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&rurl={{.RedirectURL}}" diff --git a/static/bidder-info/equativ.yaml b/static/bidder-info/equativ.yaml index 7c5214fe48e..512da14d50e 100644 --- a/static/bidder-info/equativ.yaml +++ b/static/bidder-info/equativ.yaml @@ -1 +1,2 @@ aliasOf: "smartadserver" +gvlVendorID: 45 diff --git a/static/bidder-info/freewheel-ssp.yaml b/static/bidder-info/freewheel-ssp.yaml index 43c1ca166a2..4b79dd12aba 100644 --- a/static/bidder-info/freewheel-ssp.yaml +++ b/static/bidder-info/freewheel-ssp.yaml @@ -1,4 +1,5 @@ aliasOf: freewheelssp +gvlVendorID: 285 userSync: iframe: url: "https://ads.stickyadstv.com/pbs-user-sync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&r={{.RedirectURL}}" diff --git a/static/bidder-info/magnite.yaml b/static/bidder-info/magnite.yaml index 109c20d03bf..a0840a14a86 100644 --- a/static/bidder-info/magnite.yaml +++ b/static/bidder-info/magnite.yaml @@ -1 +1,2 @@ -aliasOf: "rubicon" \ No newline at end of file +aliasOf: "rubicon" +gvlVendorID: 52 \ No newline at end of file diff --git a/static/bidder-info/showheroes-bs.yaml b/static/bidder-info/showheroes-bs.yaml index 4b49a60f182..7143e05aed4 100644 --- a/static/bidder-info/showheroes-bs.yaml +++ b/static/bidder-info/showheroes-bs.yaml @@ -1 +1,2 @@ -aliasOf: "showheroes" \ No newline at end of file +aliasOf: "showheroes" +gvlVendorID: 111 \ No newline at end of file diff --git a/static/bidder-info/showheroesBs.yaml b/static/bidder-info/showheroesBs.yaml index 4b49a60f182..7143e05aed4 100644 --- a/static/bidder-info/showheroesBs.yaml +++ b/static/bidder-info/showheroesBs.yaml @@ -1 +1,2 @@ -aliasOf: "showheroes" \ No newline at end of file +aliasOf: "showheroes" +gvlVendorID: 111 \ No newline at end of file diff --git a/static/bidder-info/ttd.yaml b/static/bidder-info/ttd.yaml index db055e1a75a..78ed8c79b51 100644 --- a/static/bidder-info/ttd.yaml +++ b/static/bidder-info/ttd.yaml @@ -1 +1,2 @@ aliasOf: thetradedesk +gvlVendorID: 21 diff --git a/static/bidder-info/yahooAdvertising.yaml b/static/bidder-info/yahooAdvertising.yaml index f9f34fbfbd0..68037fb68f0 100644 --- a/static/bidder-info/yahooAdvertising.yaml +++ b/static/bidder-info/yahooAdvertising.yaml @@ -1,4 +1,5 @@ aliasOf: yahooAds +gvlVendorID: 25 userSync: # yahooAdvertising supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. diff --git a/static/bidder-info/yahoossp.yaml b/static/bidder-info/yahoossp.yaml index 81695624dfa..132bef5a837 100644 --- a/static/bidder-info/yahoossp.yaml +++ b/static/bidder-info/yahoossp.yaml @@ -1,6 +1,7 @@ aliasOf: yahooAds maintainer: email: "hb-fe-tech@oath.com" +gvlVendorID: 25 userSync: # yahoossp supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync.