From b60253f724ffe1132db6d8e11ecc599f10f6cde4 Mon Sep 17 00:00:00 2001 From: johwier Date: Wed, 17 Dec 2025 09:37:32 -0800 Subject: [PATCH] Cnvr adapter: pass prebids version number through for better tracking --- adapters/conversant/conversant.go | 6 +++++- adapters/conversant/conversanttest/exemplary/banner.json | 1 - .../conversant/conversanttest/exemplary/simple-native.json | 3 +-- .../conversant/conversanttest/exemplary/simple_app.json | 1 - .../conversanttest/exemplary/simple_audio_app.json | 1 - .../conversanttest/exemplary/simple_audio_site.json | 1 - adapters/conversant/conversanttest/exemplary/video.json | 1 - .../conversanttest/supplemental/server_badresponse.json | 1 - .../conversanttest/supplemental/server_nocontent.json | 1 - .../conversanttest/supplemental/server_unknownstatus.json | 1 - .../conversant/conversanttest/supplemental/test_params.json | 4 ---- 11 files changed, 6 insertions(+), 15 deletions(-) diff --git a/adapters/conversant/conversant.go b/adapters/conversant/conversant.go index 035ee14bae5..4ad8d6887f5 100644 --- a/adapters/conversant/conversant.go +++ b/adapters/conversant/conversant.go @@ -3,6 +3,7 @@ package conversant import ( "encoding/json" "fmt" + "github.com/prebid/prebid-server/v3/version" "net/http" "strings" @@ -84,7 +85,10 @@ func (c *ConversantAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo * func parseCnvrParams(imp *openrtb2.Imp, cnvrExt openrtb_ext.ExtImpConversant, reqInfo *adapters.ExtraRequestInfo) []error { imp.DisplayManager = "prebid-s2s" - imp.DisplayManagerVer = "2.0.0" + + if version.Ver != "" { + imp.DisplayManagerVer = version.Ver + } if imp.BidFloor <= 0 && cnvrExt.BidFloor > 0 { imp.BidFloor = cnvrExt.BidFloor diff --git a/adapters/conversant/conversanttest/exemplary/banner.json b/adapters/conversant/conversanttest/exemplary/banner.json index 8523bb671d7..c84c9405db0 100644 --- a/adapters/conversant/conversanttest/exemplary/banner.json +++ b/adapters/conversant/conversanttest/exemplary/banner.json @@ -42,7 +42,6 @@ "secure": 1, "bidfloor": 0.01, "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "banner": { "format": [{"w": 300, "h": 250}] }, diff --git a/adapters/conversant/conversanttest/exemplary/simple-native.json b/adapters/conversant/conversanttest/exemplary/simple-native.json index f1c67e548a3..e32dad2f080 100644 --- a/adapters/conversant/conversanttest/exemplary/simple-native.json +++ b/adapters/conversant/conversanttest/exemplary/simple-native.json @@ -35,7 +35,6 @@ "secure": 1, "bidfloor": 0.01, "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "ext": { "bidder": { "site_id": "108060", @@ -97,4 +96,4 @@ ] } ] -} \ No newline at end of file +} diff --git a/adapters/conversant/conversanttest/exemplary/simple_app.json b/adapters/conversant/conversanttest/exemplary/simple_app.json index a4c825e1f64..e3ef3db1c22 100644 --- a/adapters/conversant/conversanttest/exemplary/simple_app.json +++ b/adapters/conversant/conversanttest/exemplary/simple_app.json @@ -46,7 +46,6 @@ "secure": 1, "bidfloor": 0.01, "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "banner": { "format": [{"w": 300, "h": 250}] }, diff --git a/adapters/conversant/conversanttest/exemplary/simple_audio_app.json b/adapters/conversant/conversanttest/exemplary/simple_audio_app.json index fd0b0910859..64ae1625207 100644 --- a/adapters/conversant/conversanttest/exemplary/simple_audio_app.json +++ b/adapters/conversant/conversanttest/exemplary/simple_audio_app.json @@ -42,7 +42,6 @@ "secure": 1, "bidfloor": 0.01, "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "audio": { "mimes": [ "audio/vnd.wav", "audio/mpeg", "audio/mp4" ], "protocols": [3,6,7,8] diff --git a/adapters/conversant/conversanttest/exemplary/simple_audio_site.json b/adapters/conversant/conversanttest/exemplary/simple_audio_site.json index fb74e0b6735..d2b4f849c3b 100644 --- a/adapters/conversant/conversanttest/exemplary/simple_audio_site.json +++ b/adapters/conversant/conversanttest/exemplary/simple_audio_site.json @@ -44,7 +44,6 @@ "secure": 1, "bidfloor": 0.01, "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "audio": { "mimes": [ "audio/vnd.wav", "audio/mpeg", "audio/mp4" ], "protocols": [3,6,7,8] diff --git a/adapters/conversant/conversanttest/exemplary/video.json b/adapters/conversant/conversanttest/exemplary/video.json index 322e28ad518..023b159cd98 100644 --- a/adapters/conversant/conversanttest/exemplary/video.json +++ b/adapters/conversant/conversanttest/exemplary/video.json @@ -63,7 +63,6 @@ "bidfloor": 25.0, "bidfloorcur": "USD", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "video": { "w": 300, "h": 250, diff --git a/adapters/conversant/conversanttest/supplemental/server_badresponse.json b/adapters/conversant/conversanttest/supplemental/server_badresponse.json index 26c74eaa662..60e9b78bf3c 100644 --- a/adapters/conversant/conversanttest/supplemental/server_badresponse.json +++ b/adapters/conversant/conversanttest/supplemental/server_badresponse.json @@ -31,7 +31,6 @@ { "id": "1", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "banner": { "format": [{"w": 300, "h": 250}] }, diff --git a/adapters/conversant/conversanttest/supplemental/server_nocontent.json b/adapters/conversant/conversanttest/supplemental/server_nocontent.json index ca33f470a5b..4faff08b96c 100644 --- a/adapters/conversant/conversanttest/supplemental/server_nocontent.json +++ b/adapters/conversant/conversanttest/supplemental/server_nocontent.json @@ -31,7 +31,6 @@ { "id": "1", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "banner": { "format": [{"w": 300, "h": 250}] }, diff --git a/adapters/conversant/conversanttest/supplemental/server_unknownstatus.json b/adapters/conversant/conversanttest/supplemental/server_unknownstatus.json index 129b6fba025..acb97414358 100644 --- a/adapters/conversant/conversanttest/supplemental/server_unknownstatus.json +++ b/adapters/conversant/conversanttest/supplemental/server_unknownstatus.json @@ -31,7 +31,6 @@ { "id": "1", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "banner": { "format": [{"w": 300, "h": 250}] }, diff --git a/adapters/conversant/conversanttest/supplemental/test_params.json b/adapters/conversant/conversanttest/supplemental/test_params.json index 41366dbe19b..ce3efc35d05 100644 --- a/adapters/conversant/conversanttest/supplemental/test_params.json +++ b/adapters/conversant/conversanttest/supplemental/test_params.json @@ -108,7 +108,6 @@ "secure": 1, "tagid": "mytag", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "video": { "api": [1,2], "maxduration": 60, @@ -127,7 +126,6 @@ "secure": 1, "tagid": "mytag", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "video": { "api": [1,2], "maxduration": 60, @@ -155,7 +153,6 @@ "secure": 1, "tagid": "mytag", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "video": { "api": [1,2], "maxduration": 60, @@ -183,7 +180,6 @@ "secure": 1, "tagid": "mytag", "displaymanager": "prebid-s2s", - "displaymanagerver": "2.0.0", "video": { "api": [1,2], "maxduration": 60,