Skip to content

Commit 6dda300

Browse files
committed
Fixed Github Actions by updating upload-artifact, fixed equal artifact names on some platforms:
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
1 parent de96731 commit 6dda300

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

.github/workflows/build.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,13 @@ jobs:
9191
shell: bash
9292
run: python -m build --wheel
9393

94-
- uses: actions/upload-artifact@v3 # upload test results
94+
- uses: actions/upload-artifact@v4 # upload test results
9595
if: success() || failure() # run this step even if previous step failed
9696
with:
97-
name: test-results
97+
name: test-results-linux
9898
path: ${{github.workspace}}/build/**/result-junit-linux.xml
9999

100-
- uses: actions/upload-artifact@v3 # upload python module
100+
- uses: actions/upload-artifact@v4 # upload python module
101101
name: Saving Python artifacts
102102
if: success()
103103
with:
@@ -180,13 +180,13 @@ jobs:
180180
emcmake cmake .. -DBGCODE_AS_SUBPROJECT=ON -DLibBGCode_BUILD_TESTS=OFF -DCMAKE_FIND_ROOT_PATH=$(pwd)/../../deps/build-wasm/destdir/usr/local
181181
cmake --build .
182182
183-
- uses: actions/upload-artifact@v3 # upload test results
183+
- uses: actions/upload-artifact@v4 # upload test results
184184
if: success() || failure() # run this step even if previous step failed
185185
with:
186-
name: test-results
186+
name: test-results-wasm
187187
path: ${{github.workspace}}/build/**/result-junit-wasm.xml
188188

189-
- uses: actions/upload-artifact@v3 # upload wasm module
189+
- uses: actions/upload-artifact@v4 # upload wasm module
190190
name: Saving WebAssembly artifacts
191191
if: success()
192192
with:
@@ -278,13 +278,13 @@ jobs:
278278
working-directory: ${{github.workspace}}
279279
run: python -m build --wheel
280280

281-
- uses: actions/upload-artifact@v3 # upload test results
281+
- uses: actions/upload-artifact@v4 # upload test results
282282
if: success() || failure() # run this step even if previous step failed
283283
with:
284284
name: test-results-msvc
285285
path: ${{github.workspace}}\build\**\result-junit-msvc.xml
286286

287-
- uses: actions/upload-artifact@v3 # upload python module
287+
- uses: actions/upload-artifact@v4 # upload python module
288288
name: Saving Python artifacts
289289
if: success()
290290
with:
@@ -381,13 +381,13 @@ jobs:
381381
cmake .. -DCMAKE_OSX_DEPLOYMENT_TARGET=10.12 -DBGCODE_AS_SUBPROJECT=ON -DLibBGCode_BUILD_TESTS=OFF -DCMAKE_PREFIX_PATH=${{github.workspace}}/deps/build-python-module/destdir/usr/local
382382
cmake --build .
383383
384-
- uses: actions/upload-artifact@v3 # upload test results
384+
- uses: actions/upload-artifact@v4 # upload test results
385385
if: success() || failure() # run this step even if previous step failed
386386
with:
387-
name: test-results
387+
name: test-results-mac
388388
path: ${{github.workspace}}/build/**/result-junit-mac.xml
389389

390-
- uses: actions/upload-artifact@v3 # upload python module
390+
- uses: actions/upload-artifact@v4 # upload python module
391391
name: Saving Python artifacts
392392
if: success()
393393
with:

0 commit comments

Comments
 (0)