Deprecate `nub` and rename to `removeDuplicates`

[i-am-the-slime]

I consider myself a fairly competent n-th-language speaker of English. I have never seen the word nub being used outside of PS/Haskell, however. For this reason, and motivated by #222 I suggest we deprecate nub and rename it to removeDuplicates.

Additional "reading": https://impurepics.com/posts/2021-09-26-nub.html

[sigma-andex]

Other a bit shorter names would be distinct (see e.g. in Scala ) or deduplicate.

[JordanMartinez]

I think I'd be in favor of distinct

[garyb]

I'm fine with the isEmpty idea since it's already used for some collections and null for others, and isEmpty is an unambiguous obvious choice for the name. But this would take me quite a while to adjust to since there is no precedence for an alternative name for it in PS, and also I'd never remember if it was uniq, uniques, deduplicate, distinct, etc. 😉

[sigma-andex]

But this would take me quite a while to adjust to since there is no precedence for an alternative name for it in PS, and also I'd never remember if it was uniq, uniques, deduplicate, distinct, etc.

I would argue that a newcomer would probably search for these words and eventually find it. But it would pretty much surprise me if they would search for nub 😉

[i-am-the-slime]

I'd never remember if it was uniq, uniques, deduplicate, distinct, etc. 😉

But at least that'd just be about two tries with autocomplete on 😁

[i-am-the-slime]

Okay since there were no strong voices in favour of this, I'll close this.

[sigma-andex]

@i-am-the-slime as @JordanMartinez proposed I will post these RFC to discourse. Hopefully will get to it over the weekend or early next week.