From 72396a9c3b4fbf5210662c8dd6289277cdbdee21 Mon Sep 17 00:00:00 2001 From: wyattscarpenter Date: Sat, 13 Dec 2025 05:05:16 -0800 Subject: [PATCH 1/5] slight refactor --- mypy/options.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mypy/options.py b/mypy/options.py index a9e31218ae42..2c350ffc2df3 100644 --- a/mypy/options.py +++ b/mypy/options.py @@ -457,17 +457,17 @@ def __repr__(self) -> str: def process_error_codes(self, *, error_callback: Callable[[str], Any]) -> None: # Process `--enable-error-code` and `--disable-error-code` flags - disabled_codes = set(self.disable_error_code) - enabled_codes = set(self.enable_error_code) + disabled_code_names = set(self.disable_error_code) + enabled_code_names = set(self.enable_error_code) - valid_error_codes = set(error_codes.keys()) + valid_error_code_namess = set(error_codes.keys()) - invalid_codes = (enabled_codes | disabled_codes) - valid_error_codes - if invalid_codes: - error_callback(f"Invalid error code(s): {', '.join(sorted(invalid_codes))}") + invalid_code_names_here = (enabled_code_names | disabled_code_names) - valid_error_code_namess + if invalid_code_names_here: + error_callback(f"Invalid error code(s): {', '.join(sorted(invalid_code_names_here))}") - self.disabled_error_codes |= {error_codes[code] for code in disabled_codes} - self.enabled_error_codes |= {error_codes[code] for code in enabled_codes} + self.disabled_error_codes |= {error_codes[code] for code in disabled_code_names} + self.enabled_error_codes |= {error_codes[code] for code in enabled_code_names} # Enabling an error code always overrides disabling self.disabled_error_codes -= self.enabled_error_codes From 29e86d8aa2203d57bee3a8535cdd8a5a20bc4118 Mon Sep 17 00:00:00 2001 From: wyattscarpenter Date: Sun, 18 Jan 2026 23:03:03 -0800 Subject: [PATCH 2/5] make it a real docstring --- mypy/options.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mypy/options.py b/mypy/options.py index 2c350ffc2df3..782b7e800329 100644 --- a/mypy/options.py +++ b/mypy/options.py @@ -456,7 +456,7 @@ def __repr__(self) -> str: return f"Options({pprint.pformat(self.snapshot())})" def process_error_codes(self, *, error_callback: Callable[[str], Any]) -> None: - # Process `--enable-error-code` and `--disable-error-code` flags + """Process `--enable-error-code` and `--disable-error-code` flags""" disabled_code_names = set(self.disable_error_code) enabled_code_names = set(self.enable_error_code) From fdaa8f891fbf8d81801678ba61f8d07b7c5a1d50 Mon Sep 17 00:00:00 2001 From: wyattscarpenter Date: Sun, 18 Jan 2026 23:04:01 -0800 Subject: [PATCH 3/5] typo --- mypy/options.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mypy/options.py b/mypy/options.py index 782b7e800329..9c6cc4b95f5e 100644 --- a/mypy/options.py +++ b/mypy/options.py @@ -460,9 +460,9 @@ def process_error_codes(self, *, error_callback: Callable[[str], Any]) -> None: disabled_code_names = set(self.disable_error_code) enabled_code_names = set(self.enable_error_code) - valid_error_code_namess = set(error_codes.keys()) + valid_error_code_names = set(error_codes.keys()) - invalid_code_names_here = (enabled_code_names | disabled_code_names) - valid_error_code_namess + invalid_code_names_here = (enabled_code_names | disabled_code_names) - valid_error_code_names if invalid_code_names_here: error_callback(f"Invalid error code(s): {', '.join(sorted(invalid_code_names_here))}") From 515e83f1420a175500c76c818eaefdb34b685abc Mon Sep 17 00:00:00 2001 From: wyattscarpenter Date: Sun, 18 Jan 2026 23:05:37 -0800 Subject: [PATCH 4/5] punc --- mypy/options.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mypy/options.py b/mypy/options.py index 9c6cc4b95f5e..865553edc1e6 100644 --- a/mypy/options.py +++ b/mypy/options.py @@ -456,7 +456,7 @@ def __repr__(self) -> str: return f"Options({pprint.pformat(self.snapshot())})" def process_error_codes(self, *, error_callback: Callable[[str], Any]) -> None: - """Process `--enable-error-code` and `--disable-error-code` flags""" + """Process `--enable-error-code` and `--disable-error-code` flags.""" disabled_code_names = set(self.disable_error_code) enabled_code_names = set(self.enable_error_code) From 1827738d0311069931fa27f6cb3d30a9b9f5c6a3 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 19 Jan 2026 07:12:57 +0000 Subject: [PATCH 5/5] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- mypy/options.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mypy/options.py b/mypy/options.py index 865553edc1e6..25703c6aadbd 100644 --- a/mypy/options.py +++ b/mypy/options.py @@ -462,7 +462,9 @@ def process_error_codes(self, *, error_callback: Callable[[str], Any]) -> None: valid_error_code_names = set(error_codes.keys()) - invalid_code_names_here = (enabled_code_names | disabled_code_names) - valid_error_code_names + invalid_code_names_here = ( + enabled_code_names | disabled_code_names + ) - valid_error_code_names if invalid_code_names_here: error_callback(f"Invalid error code(s): {', '.join(sorted(invalid_code_names_here))}")