refactor: move out ClasspathProvider and Binaries of the spec_builder module

Author: rcasia

lua/neotest-java/core/spec_builder/init.lua

@@ -28,29 +28,28 @@ local Binaries = require("neotest-java.command.binaries")
 
 local SpecBuilder = {}
 
+local should_not_reach_here = function()
+	error("should not reach here")
+end
+
 --- @type neotest-java.BuildSpecDependencies
 local DEFAULT_DEPENDENCIES = {
-	mkdir = function()
-		error("should not reach here")
-	end,
-
-	chdir = function()
-		error("should not reach here")
-	end,
-
-	root_getter = function()
-		error("should not reach here")
-	end,
-
+	binaries = Binaries({
+		client_provider = should_not_reach_here,
+	}),
+	mkdir = should_not_reach_here,
+	chdir = should_not_reach_here,
+	root_getter = should_not_reach_here,
+	classpath_provider = ClasspathProvider({ client_provider = should_not_reach_here }),
+
+	-- TODO: pending to remove dependencies from this scope
 	scan = scan,
-
 	compile = function(cwd, compile_mode)
 		compilers.lsp.compile({
 			base_dir = cwd,
 			compile_mode = compile_mode,
 		})
 	end,
-	classpath_provider = ClasspathProvider({ client_provider = client_provider }),
 	report_folder_name_gen = function(module_dir, build_dir)
 		local base = (module_dir and module_dir:append(build_dir:to_string())) or build_dir
 		return base:append("junit-reports"):append(nio.fn.strftime("%d%m%y%H%M%S"))
@@ -61,7 +60,6 @@ local DEFAULT_DEPENDENCIES = {
 	detect_project_type = function(base_dir)
 		return detect_project_type(base_dir)
 	end,
-	binaries = Binaries({ client_provider = client_provider }),
 }
 
 ---@param args neotest.RunArgs

lua/neotest-java/init.lua

@@ -1,4 +1,5 @@
 local File = require("neotest.lib.file")
+local client_provider = require("neotest-java.core.spec_builder.compiler.client_provider")
 
 local FileChecker = require("neotest-java.core.file_checker")
 local root_finder = require("neotest-java.core.root_finder")
@@ -12,6 +13,8 @@ local Path = require("neotest-java.model.path")
 local nio = require("nio")
 local logger = require("neotest-java.logger")
 local install = require("neotest-java.install")
+local Binaries = require("neotest-java.command.binaries")
+local ClasspathProvider = require("neotest-java.core.spec_builder.compiler.classpath_provider")
 
 local DEFAULT_CONFIG = require("neotest-java.default_config")
 
@@ -96,6 +99,10 @@ local function NeotestJavaAdapter(config, deps)
 			check_junit_jar(config.junit_jar, config.default_version)
 
 			return spec_builder.build_spec(args, config, {
+				classpath_provider = ClasspathProvider({ client_provider = client_provider }),
+				binaries = Binaries({
+					client_provider = client_provider,
+				}),
 				root_getter = root_getter,
 				mkdir = mkdir,
 				chdir = chdir,