Skip to content

wifi_ctrl_wifiapi_handlers: fix null pointer dereference in wifiapi_handle_get_ApAssocDeviceDiagnosticResult #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svc-rdkeportal01 wants to merge 1 commit into
base: topic/coverity
Choose a base branch
from
Open

wifi_ctrl_wifiapi_handlers: fix null pointer dereference in wifiapi_handle_get_ApAssocDeviceDiagnosticResult #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/core/wifi_ctrl_wifiapi_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,10 @@ static void wifiapi_handle_get_ApAssocDeviceDiagnosticResult(char **args, unsign
}
return;
}
if (dev_array == NULL) {
snprintf(result_buf, result_buf_size, "Error: dev_array is NULL\n");
return;
}
char* to_sta_key(uint8_t *mac_address, sta_key_t sta_key) {
snprintf(sta_key, STA_KEY_LEN, "%02x:%02x:%02x:%02x:%02x:%02x",
mac_address[0], mac_address[1], mac_address[2],
Expand Down Expand Up @@ -660,11 +664,11 @@ static void wifiapi_handle_get_ApAssocDeviceDiagnosticResult(char **args, unsign
dev_array[i].cli_MultipleRetryCount, dev_array[i].cli_MaxDownlinkRate,
dev_array[i].cli_MaxUplinkRate, dev_array[i].cli_activeNumSpatialStreams,
dev_array[i].cli_TxFrames, dev_array[i].cli_RxRetries, dev_array[i].cli_RxErrors);
}
if (dev_array != NULL) {
free(dev_array);
dev_array = NULL;
}
}
}

void process_wifiapi_command(char *command, unsigned int len)
Expand Down