Skip to content

wifi_ctrl_webconfig: fix null pointer dereference in webconfig_vif_neighbors_apply #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svc-rdkeportal01 wants to merge 1 commit into
base: topic/coverity
Choose a base branch
from
Open

wifi_ctrl_webconfig: fix null pointer dereference in webconfig_vif_neighbors_apply #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion source/core/wifi_ctrl_webconfig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,6 +1262,11 @@ int webconfig_vif_neighbors_apply(wifi_ctrl_t *ctrl, webconfig_subdoc_decoded_da

wifi_util_dbg_print(WIFI_MGR,"%s %d \n", __func__, __LINE__);

if (data == NULL) {
wifi_util_error_print(WIFI_MGR,"%s:%d data is NULL\n", __func__, __LINE__);
return RETURN_ERR;
}

mgr_cfg_map = mgr->vif_neighbors_map;
dec_cfg_map = data->vif_neighbors_map;

Expand Down Expand Up @@ -1319,7 +1324,7 @@ int webconfig_vif_neighbors_apply(wifi_ctrl_t *ctrl, webconfig_subdoc_decoded_da
}
}
free_data:
if ((data != NULL) && (dec_cfg_map != NULL)) {
if (dec_cfg_map != NULL) {
wifi_util_dbg_print(WIFI_MGR,"%s %d Freeing Decoded Data \n", __func__, __LINE__);
dec_vif_neighbors = hash_map_get_first(dec_cfg_map);
while (dec_vif_neighbors != NULL) {
Expand Down