Skip to content

Datamodel markers should ignore marker value as zero #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dharshini555 wants to merge 3 commits into
base: develop
Choose a base branch
from
+7 −1
Open

Datamodel markers should ignore marker value as zero #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a45d71
Datamodel markers should ignore marker value as zero
PriyaKathiravan Feb 3, 2026
09e620a
Datamodel markers should ignore marker value as zero
PriyaKathiravan Feb 3, 2026
4f4b05a
Merge branch 'topic/dm_value' of https://github.com/rdkcentral/teleme…
PriyaKathiravan Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/reportgen/reportgen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ static bool checkForEmptyString( char* valueString )
{
// rbusInterface implementation explicitly adds string as "NULL" for parameters which doesn't exist on device
// Consider "NULL" string value as qualified for empty string
if(strlen(valueString) < 1 || !strncmp(valueString, " ", 1) || !strncmp(valueString, "NULL", 4))
// If the string has zero value it should be ignored
if(strlen(valueString) < 1 || !strncmp(valueString, " ", 1) || !strcmp(valueString, "0") || !strncmp(valueString, "NULL", 4))
{
isEmpty = true ;
T2Debug("Marker Value is empty or zero or NULL\n");
}
}
else
Expand Down
4 changes: 4 additions & 0 deletions test/functional-tests/tests/test_xconf_communications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,14 @@ def test_xconf_datamodel():
assert "Test_datamodel_1" in grep_T2logs("cJSON Report")
kill_telemetry(29)
sleep(5)
rbus_set_data("Device.DeviceInfo.X_RDKCENTRAL-COM.IUI.Version", "string", "0.1")
kill_telemetry(29)
sleep(5)
assert "IUI_accum" in grep_T2logs("cJSON Report")
rbus_set_data("Device.DeviceInfo.X_RDKCENTRAL-COM.IUI.Version", "string", "0")
kill_telemetry(29)
sleep(5)
assert "IUI_accum" not in grep_T2logs("cJSON Report")
assert "Test_datamodel_1" in grep_T2logs("cJSON Report")

pytest.mark.run(order=15)
Expand Down