Skip to content

Switch native_full_build container to ubuntu:22.04 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scthunderbolt wants to merge 7 commits into from
Closed

Switch native_full_build container to ubuntu:22.04 #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
620185a
Switch native_full_build container to ubuntu:22.04
scthunderbolt Jan 15, 2026
dd5e10e
Add apt install git
scthunderbolt Jan 15, 2026
830567c
Add apt install libcurl4-openssl-dev
scthunderbolt Jan 15, 2026
3aaf6a9
Consolidate the apt install lines
scthunderbolt Jan 15, 2026
4f4c7b2
Upgrade pip to pip3
scthunderbolt Jan 15, 2026
ef827a6
Switch apt to apt-get
scthunderbolt Jan 15, 2026
badeeae
Tidy up apt-get install lines
scthunderbolt Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/native_full_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ jobs:
build-entservices-on-pr:
name: Build xdialserver component in github rdkcentral
runs-on: ubuntu-latest
container:
image: ghcr.io/rdkcentral/docker-rdk-ci:latest
container: ubuntu:22.04

steps:
- name: Checkout code
Expand Down
25 changes: 22 additions & 3 deletions build_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,28 @@ cd ${GITHUB_WORKSPACE}
# # #############################
#1. Install Dependencies and packages

Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider setting DEBIAN_FRONTEND=noninteractive before running apt-get commands to prevent interactive prompts during package installation in CI environments. This can be done by adding export DEBIAN_FRONTEND=noninteractive before the apt-get commands or by prefixing the commands with the environment variable.

Suggested change
export DEBIAN_FRONTEND=noninteractive

Copilot uses AI. Check for mistakes.
apt update
apt install -y ninja-build meson curl libsoup2.4-dev libxml2-dev libglib2.0-dev gobject-introspection libgirepository1.0-dev libgtk-3-dev valac pandoc
pip install jsonref
apt-get update
apt-get install -y \
git \
python3 \
python3-pip \
cmake \
libcunit1 \
libcunit1-doc \
libcunit1-dev \
libcurl4-openssl-dev \
ninja-build \
meson \
curl \
libsoup2.4-dev \
libxml2-dev \
libglib2.0-dev \
gobject-introspection \
libgirepository1.0-dev \
libgtk-3-dev \
valac \
pandoc
Comment on lines +13 to +32
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build-essential package (or at minimum make and g++) is missing from the package installation list. The build scripts use make (in cov_build.sh line 13 and Makefile) and g++ (in build_dependencies.sh lines 145-146). Without these tools, the build will fail. Add build-essential to the apt-get install command.

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +32
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pkg-config package should be added to the installation list. It is commonly required by meson and cmake build systems to locate library dependencies, especially for the GTK and GNOME libraries being installed (libglib2.0-dev, libgtk-3-dev, etc.). While it might be installed as a transitive dependency, explicitly including it ensures more reliable builds.

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +32
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build script uses the patch command (lines 82, 101-104 of build_dependencies.sh) but patch is not included in the package installation list. Add patch to the apt-get install command to ensure patches can be applied successfully.

Copilot uses AI. Check for mistakes.
pip3 install jsonref

############################
# Build trevor-base64
Expand Down