Skip to content

CMFSUPPORT-3699 Coverity TEST. DO NOT MERGE #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scthunderbolt wants to merge 4 commits into from
+1 −1
Closed

CMFSUPPORT-3699 Coverity TEST. DO NOT MERGE #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4c6d28
CMFSUPPORT-3699 Coverity TEST. DO NOT MERGE
scthunderbolt Jan 22, 2026
65c5112
TEST
scthunderbolt Jan 22, 2026
8fdca8d
TEST
scthunderbolt Jan 22, 2026
7414854
TEST
scthunderbolt Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ How to contribute
3. Submit a PR against the chosen sprint branch.
4. The PR will be reviewed and if accepted merged into the sprint branch.
5. All changes in sprint branch are accepted into release branch `stable2` by planned releases.

1 change: 0 additions & 1 deletion server/plat/gdial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ class GDialCastObject
{
GDIAL_LOGINFO("AppName[%s] AppID[%s] State[%s] Error[%s]",
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Missing argument to printf format specifier

No argument for format specifier "%s".

Medium Impact, CWE-685
PRINTF_ARGS

AppObj->appName.c_str(),
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format string expects 4 arguments (AppName, AppID, State, Error) but only 3 arguments are now provided after removing the appId parameter. This will cause undefined behavior and potentially a crash when the logging function tries to read the missing argument. Either remove the "AppID[%s]" placeholder from the format string or restore the appId.c_str() argument.

Suggested change
AppObj->appName.c_str(),
AppObj->appName.c_str(),
AppObj->appId.c_str(),

Copilot uses AI. Check for mistakes.
AppObj->appId.c_str(),
AppObj->appState.c_str(),
AppObj->appError.c_str());
if ( AppCacheError_OK == AppCache->UpdateAppStatusCache(AppObj))
Expand Down
Loading