From 1b41a1713646f8e672cda666d28722fc0fb2cb9b Mon Sep 17 00:00:00 2001 From: Daniel Markstedt Date: Mon, 5 Jan 2026 22:02:55 +0100 Subject: [PATCH 1/3] add GitHub workflow job for checking coding style and linting --- .github/workflows/test.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9861314..00a1922 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,3 +23,17 @@ jobs: nc -z localhost 5005 sleep 2 kill $PID + + code_standards: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + - uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 + with: + python-version: 3.9.25 + cache: 'pip' + - run: pip install -r requirements-dev.txt + id: pip + - run: black --check . + - run: flake8 . + if: success() || failure() && steps.pip.outcome == 'success' From 04bc3c6259ac668c3a97be9590cbe511d6030695 Mon Sep 17 00:00:00 2001 From: Daniel Markstedt Date: Mon, 5 Jan 2026 22:17:03 +0100 Subject: [PATCH 2/3] reformat python code with black --- proxy.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/proxy.py b/proxy.py index aa807a2..00a9d9e 100644 --- a/proxy.py +++ b/proxy.py @@ -385,7 +385,11 @@ def process_response(response, url): response = Response(content, status_code) for key, value in headers.items(): - if key.lower() not in ["content-encoding", "content-length", "transfer-encoding"]: + if key.lower() not in [ + "content-encoding", + "content-length", + "transfer-encoding", + ]: response.headers[key] = value debug_print("Finished processing response") From 1c04c2e9a40e673d9d992db930aaf65d3fd19c03 Mon Sep 17 00:00:00 2001 From: Daniel Markstedt Date: Mon, 5 Jan 2026 22:23:10 +0100 Subject: [PATCH 3/3] don't declare global variables in scopes when they are only read --- extensions/override/override.py | 1 - extensions/waybackmachine/waybackmachine.py | 1 - proxy.py | 1 - 3 files changed, 3 deletions(-) diff --git a/extensions/override/override.py b/extensions/override/override.py index cba22e8..5a0937a 100644 --- a/extensions/override/override.py +++ b/extensions/override/override.py @@ -26,7 +26,6 @@ def get_override_status(): - global override_active return override_active diff --git a/extensions/waybackmachine/waybackmachine.py b/extensions/waybackmachine/waybackmachine.py index 95ab92b..f7612d9 100644 --- a/extensions/waybackmachine/waybackmachine.py +++ b/extensions/waybackmachine/waybackmachine.py @@ -99,7 +99,6 @@ def get_override_status(): - global override_active return override_active diff --git a/proxy.py b/proxy.py index 00a9d9e..a69a7b3 100644 --- a/proxy.py +++ b/proxy.py @@ -197,7 +197,6 @@ def handle_image_request(url): @app.route("/", defaults={"path": "/"}, methods=["GET", "POST"]) @app.route("/", methods=["GET", "POST"]) def handle_request(path): - global override_extension parsed_url = urlparse(request.url) scheme = parsed_url.scheme host = parsed_url.netloc.split(":")[0] # Remove port if present