remove lifetimes that can be elided, fix make lint

Author: joewagner

fendermint/rocksdb/src/kvstore.rs

@@ -208,7 +208,7 @@ where
     }
 }
 
-impl<'a, S> KVWrite<S> for RocksDbWriteTx<'a>
+impl<S> KVWrite<S> for RocksDbWriteTx<'_>
 where
     S: KVStore<Repr = Vec<u8>>,
     S::Namespace: AsRef<str>,
@@ -243,7 +243,7 @@ where
     }
 }
 
-impl<'a> KVTransaction for RocksDbWriteTx<'a> {
+impl KVTransaction for RocksDbWriteTx<'_> {
     fn commit(self) -> KVResult<()> {
         let tx = self.take_tx();
         tx.commit().map_err(to_kv_error)
@@ -255,7 +255,7 @@ impl<'a> KVTransaction for RocksDbWriteTx<'a> {
     }
 }
 
-impl<'a> Drop for RocksDbWriteTx<'a> {
+impl Drop for RocksDbWriteTx<'_> {
     fn drop(&mut self) {
         if !thread::panicking() {
             panic!("Transaction prematurely dropped. Must call `.commit()` or `.rollback()`.");

fendermint/storage/src/im.rs

@@ -120,7 +120,7 @@ pub struct Transaction<'a, S: KVStore, M> {
     _mode: M,
 }
 
-impl<'a, S: KVStore> KVTransaction for Transaction<'a, S, Write> {
+impl<S: KVStore> KVTransaction for Transaction<'_, S, Write> {
     // An exclusive lock has already been taken.
     fn commit(mut self) -> KVResult<()> {
         let mut guard = self.backend.data.lock().unwrap();
@@ -135,7 +135,7 @@ impl<'a, S: KVStore> KVTransaction for Transaction<'a, S, Write> {
     }
 }
 
-impl<'a, S: KVStore, M> Drop for Transaction<'a, S, M> {
+impl<S: KVStore, M> Drop for Transaction<'_, S, M> {
     fn drop(&mut self) {
         if self.token.is_some() && !thread::panicking() {
             panic!("Transaction prematurely dropped. Must call `.commit()` or `.rollback()`.");
@@ -177,7 +177,7 @@ where
     }
 }
 
-impl<'a, S: KVStore> KVWrite<S> for Transaction<'a, S, Write>
+impl<S: KVStore> KVWrite<S> for Transaction<'_, S, Write>
 where
     S::Repr: Hash + Eq,
 {
@@ -231,7 +231,7 @@ where
     }
 }
 
-impl<'a, S, K, V> Iterator for KVIter<'a, S, K, V>
+impl<S, K, V> Iterator for KVIter<'_, S, K, V>
 where
     S: KVStore + Decode<K> + Decode<V>,
 {