Skip to content
/ rector-src Public

[DeadCode] No need additional parentheses () on multiply to function call on RemoveDeadZeroAndOneOperationRector #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 5 commits into from
Feb 5, 2026
+56 −1
Merged

[DeadCode] No need additional parentheses () on multiply to function call on RemoveDeadZeroAndOneOperationRector #7883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45d9a07
[DeadCode] No need additional parentheses () on multiply to function …
samsonasik Feb 5, 2026
5e4a11b
fix
samsonasik Feb 5, 2026
5b4d773
fix
samsonasik Feb 5, 2026
61735d9
add spaced
samsonasik Feb 5, 2026
10dee67
add spaced
samsonasik Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ...de/Rector/Plus/RemoveDeadZeroAndOneOperationRector/Fixture/multiply_function_call.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Plus\RemoveDeadZeroAndOneOperationRector\Fixture;

class MultiplyFunctionCall
{
public function run(string $a)
{
$b = 1 * strlen($a) * 4;
}
}

?>
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Plus\RemoveDeadZeroAndOneOperationRector\Fixture;

class MultiplyFunctionCall
{
public function run(string $a)
{
$b = strlen($a) * 4;
}
}

?>
2 changes: 2 additions & 0 deletions ...DeadCode/Rector/Plus/RemoveDeadZeroAndOneOperationRector/Fixture/with_parentheses.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class WithParentheses
public function run()
{
$a = 1 * (2 + 3) * 4;
$a = 1 * ( 2 + 3 ) * 4;
}
}

Expand All @@ -21,6 +22,7 @@ class WithParentheses
public function run()
{
$a = (2 + 3) * 4;
$a = (2 + 3) * 4;
}
}

Expand Down
28 changes: 27 additions & 1 deletion rules/DeadCode/Rector/Plus/RemoveDeadZeroAndOneOperationRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,36 @@ private function processBinaryPlusAndMinus(Plus | Minus $binaryOp): ?Expr

private function isMulParenthesized(File $file, Mul $mul): bool
{
if (! $mul->right instanceof BinaryOp) {
return false;
}

$oldTokens = $file->getOldTokens();
$endTokenPost = $mul->getEndTokenPos();

return isset($oldTokens[$endTokenPost]) && (string) $oldTokens[$endTokenPost] === ')';
if (isset($oldTokens[$endTokenPost]) && (string) $oldTokens[$endTokenPost] === ')') {
$startTokenPos = $mul->right->getStartTokenPos();
$previousEndTokenPost = $mul->left->getEndTokenPos();

while ($startTokenPos > $previousEndTokenPost) {
--$startTokenPos;

if (! isset($oldTokens[$startTokenPos])) {
return false;
}

// handle space before open parentheses
if (trim((string) $oldTokens[$startTokenPos]) === '') {
continue;
}

return (string) $oldTokens[$startTokenPos] === '(';
}

return false;
}

return false;
}

private function processBinaryMulAndDiv(Mul | Div $binaryOp): ?Expr
Expand Down