Skip to content

Incorrect behavior of JsonThrowOnErrorRector #9630

@abishekrsrikaanth

Description

@abishekrsrikaanth

Bug Report

Subject Details
Rector version last dev-main
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/410ae8f9-237a-4569-83f6-f16152e4a6e9

<?php

final class DemoFile
{
    public function run(bool $param)
    {
        if ($this->isTrue($param)) {
            return 5;
        }

        return '10';
    }

    private function isTrue($value)
    {
        return $value === true;
    }
    
    public function jsonTest()
    {
        $data = [1,2,3,4];
        
        return json_encode($data, JSON_PRETTY_PRINT);
    }
}

Responsible rules

  • JsonThrowOnErrorRector

Expected Behavior

Change json_encode($data, JSON_PRETTY_PRINT); to json_encode($data, JSON_THROW_ON_ERROR | JSON_PRETTY_PRINT);

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions