From 7eb2144178b20cfc7923cc2c10750679b4a4ab71 Mon Sep 17 00:00:00 2001 From: Kris Cottingham Date: Fri, 28 Feb 2025 20:59:09 +0000 Subject: [PATCH 1/4] chore: upgrade action versions [DX-4803](https://redfin.atlassian.net/browse/DX-4803) --- .github/workflows/lint.yml | 8 ++++---- .github/workflows/publish.yml | 6 +++--- .github/workflows/stylelint.yml | 2 +- .github/workflows/test.yml | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 84f339207..2378fcdbc 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -11,13 +11,13 @@ jobs: runs-on: ubuntu-latest steps: - name: check out latest commit - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: ref: ${{ github.head_ref || github.ref }} token: ${{ github.token }} - name: cache node_modules - uses: actions/cache@v2 + uses: actions/cache@v4 id: cache-node-modules with: path: node_modules/ @@ -28,7 +28,7 @@ jobs: run: echo "::set-output name=value::$( cat .node-version )" - name: set up node - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ steps.node-version.outputs.value }} registry-url: https://npm.pkg.github.com @@ -39,7 +39,7 @@ jobs: run: echo "::set-output name=dir::$(yarn cache dir)" - name: cache dependencies - uses: actions/cache@v1 + uses: actions/cache@v4 id: yarn-cache with: path: ${{ steps.yarn-cache-dir-path.outputs.dir }} diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index feed114be..545d7f2a7 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest steps: - name: clone repo with full history for lerna - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: ref: master fetch-depth: 0 @@ -19,7 +19,7 @@ jobs: run: echo "::set-output name=value::$( cat .node-version )" - name: set up node - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ steps.node-version.outputs.value }} registry-url: https://npm.pkg.github.com @@ -27,7 +27,7 @@ jobs: token: ${{ secrets.GH_GPR_TOKEN }} - name: cache node_modules - uses: actions/cache@v2 + uses: actions/cache@v4 id: cache-node-modules with: path: node_modules/ diff --git a/.github/workflows/stylelint.yml b/.github/workflows/stylelint.yml index 33da5f2c4..f8a66a698 100644 --- a/.github/workflows/stylelint.yml +++ b/.github/workflows/stylelint.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest steps: - name: check out latest commit - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: ref: ${{ github.head_ref || github.ref }} token: ${{ github.token }} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a0398a27b..53bdf4ea7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,13 +11,13 @@ jobs: runs-on: ubuntu-latest steps: - name: check out latest commit - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: ref: ${{ github.head_ref || github.ref }} token: ${{ secrets.GH_TOKEN }} - name: cache node_modules - uses: actions/cache@v2 + uses: actions/cache@v4 id: cache-node-modules with: path: node_modules/ @@ -28,7 +28,7 @@ jobs: run: echo "::set-output name=value::$( cat .node-version )" - name: set up node - uses: actions/setup-node@v1 + uses: actions/setup-node@v4 with: node-version: ${{ steps.node-version.outputs.value }} registry-url: https://npm.pkg.github.com @@ -39,7 +39,7 @@ jobs: run: echo "::set-output name=dir::$(yarn cache dir)" - name: cache dependencies - uses: actions/cache@v1 + uses: actions/cache@v4 id: yarn-cache with: path: ${{ steps.yarn-cache-dir-path.outputs.dir }} From 19225c030d0894d9aec195b05c80de656563c60e Mon Sep 17 00:00:00 2001 From: Kris Cottingham Date: Mon, 3 Mar 2025 16:09:15 +0000 Subject: [PATCH 2/4] fix: token references in workflows [DX-4803](https://redfin.atlassian.net/browse/DX-4803) --- .github/workflows/lint.yml | 2 +- .github/workflows/test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 2378fcdbc..dbf958b7a 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -49,7 +49,7 @@ jobs: - name: install dependencies env: - NODE_AUTH_TOKEN: ${{ secrets.GH_GPR_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GPR_TOKEN }} run: | yarn config set @rentpath:registry https://npm.pkg.github.com yarn --frozen-lockfile --production=false diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 53bdf4ea7..358e1e0d0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -49,7 +49,7 @@ jobs: - name: install dependencies env: - NODE_AUTH_TOKEN: ${{ secrets.GH_GPR_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GPR_TOKEN }} run: | yarn config set @rentpath:registry https://npm.pkg.github.com yarn --frozen-lockfile --production=false From da2fbd5ac997b16892022d5943a4c9b108a70ce8 Mon Sep 17 00:00:00 2001 From: Kris Cottingham Date: Mon, 3 Mar 2025 16:10:08 +0000 Subject: [PATCH 3/4] chore: disable stylelint workflow [DX-4803](https://redfin.atlassian.net/browse/DX-4803) It's trying to use an action which does not exist in a visible place. I don't know if it has been deleted, archived, or migrated to rent-corp. --- .github/workflows/stylelint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/stylelint.yml b/.github/workflows/stylelint.yml index f8a66a698..25e909a20 100644 --- a/.github/workflows/stylelint.yml +++ b/.github/workflows/stylelint.yml @@ -8,6 +8,7 @@ on: jobs: stylelint: name: stylelint + if: false runs-on: ubuntu-latest steps: - name: check out latest commit From 88c5c1c926185ad4b9faca201a087e0e74ac9c29 Mon Sep 17 00:00:00 2001 From: Kris Cottingham Date: Mon, 3 Mar 2025 16:21:53 +0000 Subject: [PATCH 4/4] fix: public repos can't use private secrets [DX-4803](https://redfin.atlassian.net/browse/DX-4803) --- .github/workflows/lint.yml | 2 +- .github/workflows/test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index dbf958b7a..ca52d288f 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -49,7 +49,7 @@ jobs: - name: install dependencies env: - NODE_AUTH_TOKEN: ${{ secrets.GPR_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GPR_PUBLIC_TOKEN }} run: | yarn config set @rentpath:registry https://npm.pkg.github.com yarn --frozen-lockfile --production=false diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 358e1e0d0..912258614 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -49,7 +49,7 @@ jobs: - name: install dependencies env: - NODE_AUTH_TOKEN: ${{ secrets.GPR_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GPR_PUBLIC_TOKEN }} run: | yarn config set @rentpath:registry https://npm.pkg.github.com yarn --frozen-lockfile --production=false