From 9061a4ac735e11ae6932798b2a304b584d5494ba Mon Sep 17 00:00:00 2001 From: Rob Date: Thu, 25 Dec 2025 12:57:32 -0500 Subject: [PATCH] fix: rescript-legacy broken for ppx's This resolves PPX errors with "Ill-formed list of warnings" after removal of -bs-v flag. The mtime from being appended to the -bs-v flag, after the change in #7627 it was being appended to the warnings flag instead, causing the compiler error Fixes #8090 Signed-off-by: Rob --- CHANGELOG.md | 1 + compiler/bsb/bsb_ninja_rule.ml | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5a395c8a21..e8aef67037 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ - Fix `@val` shadowing (rewrite using `globalThis`). https://github.com/rescript-lang/rescript/pull/8098 - Fix `@scope` shadowing (rewrite using `globalThis`). https://github.com/rescript-lang/rescript/pull/8100 - Fix rewatch panic on duplicate module name. https://github.com/rescript-lang/rescript/pull/8102 +- Fix 'Ill-formed list of warnings' errors for ppx's with rescript-legacy. https://github.com/rescript-lang/rescript/pull/8103 #### :memo: Documentation diff --git a/compiler/bsb/bsb_ninja_rule.ml b/compiler/bsb/bsb_ninja_rule.ml index b5a41f407b..d12f845b20 100644 --- a/compiler/bsb/bsb_ninja_rule.ml +++ b/compiler/bsb/bsb_ninja_rule.ml @@ -145,10 +145,6 @@ let make_custom_rules ~(gentype_config : Bsb_config_types.gentype_config) (match ppx_files with | [] -> () | _ -> - Ext_list.iter ppx_files (fun x -> - match string_of_float (Unix.stat x.name).st_mtime with - | exception _ -> () - | st -> Ext_buffer.add_char_string buf ',' st); Ext_buffer.add_char_string buf ' ' (Bsb_build_util.ppx_flags ppx_files)); (match pp_file with | None -> ()