Build Error

[MrTyton]

Hi,

I'm trying to build this, and am getting a compilation error.

make modern
/opt/devkitpro/devkitARM/bin/../libexec/gcc/arm-none-eabi/15.1.0/cc1 -quiet <flags> -o build/modern/src/event_object_movement.o src/event_object_movement.c
src/event_object_movement.c: In function 'GetFollowerInfo':
src/event_object_movement.c:2208:9: error: 'return' with no value, in function returning non-void [-Wreturn-mismatch]
 2208 |         return;
      |         ^~~~~~
src/event_object_movement.c:2203:14: note: declared here
 2203 | static bool8 GetFollowerInfo(u16 *species, u8 *form, u8 *shiny)
      |              ^~~~~~~~~~~~~~~
make: *** [Makefile:340: build/modern/src/event_object_movement.o] Error 1
make: *** Deleting file 'build/modern/src/event_object_movement.o'

Following the compilation instructions and using git clone https://github.com/resetes12/pokeemerald as the source.

Any idea how to fix?

[friendlymammal]

I ran into a similar issue when trying to compile the latest version just now. Here are some extra details about the triggering conditions and my attempted fixes, in case it's helpful:

Description
Getting compilation error(s) when trying to build with make modern.

Error

Pretty much the same as OP, but included just in case

src/event_object_movement.c: In function 'GetFollowerInfo':
src/event_object_movement.c:2208:9: error: 'return' with no value, in function returning non-void [-Wreturn-mismatch]
 2208 |         return;
      |         ^~~~~~
src/event_object_movement.c:2203:14: note: declared here
 2203 | static bool8 GetFollowerInfo(u16 *species, u8 *form, u8 *shiny)
      |              ^~~~~~~~~~~~~~~
make: *** [Makefile:340: build/modern/src/event_object_movement.o] Error 1
make: *** Deleting file 'build/modern/src/event_object_movement.o'

My setup

• Operating System: Linux Mint 22.1 Cinnamon
• Compiler: arm-none-eabi-gcc (15:13.2.rel1-2) 13.2.1 20231009
• Git commit: 54c0e5e

What I Did

1. Cloned the repository
2. Renamed a clean copy of Pokemon Emerald (USA) to baserom.gba and put it in the root directory
3. Ran make clean
4. Ran make modern
5. Got this error, assumed I did something wrong, so started from scratch and did it again with the same result :c
6. Attempted a fix, then got a different (related?) compilation error. Details below:

Other relevant info
I'm very much a newb when it comes to ROM hacks and incredibly rusty with C, so please take all of this with a lot of salt! If I'm reading it right, the GetFollowerInfo function is supposed to return a boolean, but the else statement doesn't seem to provide one on line 2208.
The function in question:

GetFollowerInfo

static bool8 GetFollowerInfo(u16 *species, u8 *form, u8 *shiny)
{
    if (gSaveBlock2Ptr->optionsfollowerEnable == 0)
        return GetMonInfo(GetFirstLiveMon(), species, form, shiny);
    else
        return;
}

Attempted fix + related issues?
I tried changing line 2208 to return FALSE; and it seemed to fix the first compilation error. I still wasn't able to compile though-- This time, it returned another compilation error in src/field_player_avatar.c:

MovementType_Player error

src/field_player_avatar.c: In function 'MovementType_Player':
src/field_player_avatar.c:327:79: error: passing argument 3 of 'UpdateObjectEventCurrentMovement' from incompatible pointer type [-Wincompatible-point
er-types]
  327 |     UpdateObjectEventCurrentMovement(&gObjectEvents[sprite->data[0]], sprite, ObjectEventCB2_NoMovement2);
      |                                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                               |
      |                                                                               u8 (*)(void) {aka unsigned char (*)(void)}
In file included from src/field_player_avatar.c:5:
include/event_object_movement.h:159:78: note: expected 'bool8 (*)(struct ObjectEvent *, struct Sprite *)' {aka 'unsigned char (*)(struct ObjectEvent *, struct Sprite *)'} but argument is of type 'u8 (*)(void)' {aka 'unsigned char (*)(void)'}
  159 | void UpdateObjectEventCurrentMovement(struct ObjectEvent *, struct Sprite *, bool8(struct ObjectEvent *, struct Sprite *));
      |                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/field_player_avatar.c:44:11: note: 'ObjectEventCB2_NoMovement2' declared here
   44 | static u8 ObjectEventCB2_NoMovement2();
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:340: build/modern/src/field_player_avatar.o] Error 1
make: *** Deleting file 'build/modern/src/field_player_avatar.o'

I'm guessing the issues are related, since they both involve follower/object event functionality, but I'm in way over my head... I hope any of this is helpful!

[resetes12]

All these issues are from not using "make modern", since sometimes I do "make" without the "modern" subcommand and I end up getting exactly the same issues, or pretty similar ones. Taking time to fix all these "issues" that happen with the old compiler, while the modern compiler just compiles with no errors, isn't feasible or fun.

Now, what I do not know is why @friendlymammal is getting the errors that shouldn't happen in "modern". All these issues are normal, and that's why I use the "modern" compiler. The only thing I can think of is how you installed the repository? Taking into account that I've done many clones of my repository and never had an issue, there might be something else. These are my steps:

• Install VSCode
• Install WSL 1 (I'm on Windows 11)
• Install Ubuntu from the Windows Store (no version, just Ubuntu with an orange, rectangular icon)
• Install git and wsl in VSCode
• Manually download my copy of pokeemerald
• Open VSCode, start the linux subsystem
• Locate the folder, and just do "make modern"

I've done these steps on many computers, always worked as expected.

[friendlymammal]

Thank you so much for the quick response! I totally understand if this kind of troubleshooting isn't fun and you're not up for supporting it.

If you're okay with sharing a little more information, would you mind checking which version of devkitARM you're using (arm-none-eabi-gcc --version)? It would be really helpful to see the output of make modern V=1 2>&1 | head -20 and make V=1 2>&1 | head -10 on your system, to understand why your make modern is more lenient than mine. No worries if this is out of scope for you though. [Edited because I kept making copy/paste errors with the commands 🙄 ]

Troubleshooting in Windows 11

Attempt to compile with VSCode and WSL 1

1. Switched to a laptop running Windows 11 and installed VSCode
2. Installed WSL 1
3. Installed Ubuntu from the Windows Store
4. Installed WSL in VSCode. Since git was preinstalled with VSCode, didn't add anything else.
5. Manually downloaded this branch of pokeemerald using the github website to get a zipfile, rather than cloning the repo like usual. Extracted it to my WSL file system.
6. Added in the baserom file
7. Opened VSCode, started the linux subsystem, and located the pokeemerald folder
8. Ran make modern and got the same error with GetFollowerInfo T_T

I'm totally stumped. In addition to trying this on Windows, I also did more troubleshooting on Linux (details below, if anyone's curious), but never managed to make it around the error. If anyone has suggestions on additional setup steps or compiler flags, I'll try about anything at this point.

Additional Windows setup details

# Commit
git log --oneline -1
54c0e5e49 (HEAD -> master, tag: Release3.0, origin/master, origin/HEAD) Fixed more tiles in Mewtwo's cave

# Compiler
which arm-none-eabi-gcc
/opt/devkitpro/devkitARM/bin/arm-none-eabi-gcc

arm-none-eabi-gcc --version
arm-none-eabi-gcc (devkitARM release 66) 15.1.0

# Environmental variables 
echo $DEVKITARM
/opt/devkitpro/devkitARM

echo $DEVKITPRO
/opt/devkitpro


# ARM tools
ls /opt/devkitpro/devkitARM/bin/ | grep -E "(objcopy|objdump|strip|ld)"
arm-none-eabi-ld
arm-none-eabi-ld.bfd
arm-none-eabi-objcopy
arm-none-eabi-objdump
arm-none-eabi-strip


# Doublechecked PATH
echo $PATH | tr ':' '\n' | grep -E "(devkit|arm)"
/opt/devkitpro/devkitARM/bin
/opt/devkitpro/tools/bin
/opt/devkitpro/devkitARM/bin
/opt/devkitpro/tools/bin

# Checked if there were actually duplicates of /opt/devkitpro, but it seems not: 
ls /opt/
devkitpro

# PIP Packages
pip3 list | grep -iE "(pil|image|png|setuptools|wheel)"
setuptools          68.1.2
wheel               0.42.0

# System Packages
dpkg -l | grep python3 | grep -iE "(pil|image|png|dev)" | awk '{print $2, $3}'
libpython3-dev:amd64 3.12.3-0ubuntu2
libpython3.12-dev:amd64 3.12.3-1ubuntu0.7
python3-dev 3.12.3-0ubuntu2
python3.12-dev 3.12.3-1ubuntu0.7

Additional Linux Troubleshooting

Additional Setup Details

1. Compiler version info
I tried make modern with 2 different versions of the compiler: the version that came installed on my OS, and a newer version.

which arm-none-eabi-gcc 
/opt/devkitpro/devkitARM/bin/arm-none-eabi-gcc

arm-none-eabi-gcc --version
arm-none-eabi-gcc (15:13.2.rel1-2) 13.2.1 20231009

and

arm-none-eabi-gcc (devkitARM release 66) 15.1.0

In both cases, I ran make clean and make modern with clean copies of the baserom. No change in error, sadly.

2. Environment variables, ARM tools, PATH info

# Environment variables:
echo $DEVKITARM
/opt/devkitpro/devkitARM

echo $DEVKITPRO
/optdevkitpro

# ARM tools
ls /opt/devkitpro/devkitARM/bin/ | grep -E "(objcopy|objdump|strip|ld)"
arm-none-eabi-ld
arm-none-eabi-ld.bfd
arm-none-eabi-objcopy
arm-none-eabi-objdump
arm-none-eabi-strip

# Doublechecked PATH 
echo $PATH | tr ':' '\n' | grep -E "(devkit|arm)"
/opt/devkitpro/tools/bin

3. Python imaging and build-related packages

# PIP packages
pip3 list | grep -iE "(pil|image|png|setuptools|wheel)"
pillow                10.2.0
pypng                 0.20231004.0
setuptools            68.1.2
wheel                 0.42.0

# System packages
dpkg -l | grep python3 | grep -iE "(pil|image|png|dev)" | awk '{print $2, $3}'
libpython3-dev:amd64 3.12.3-0ubuntu2
libpython3.12-dev:amd64 3.12.3-1ubuntu0.7
python3-dev 3.12.3-0ubuntu2
python3-libevdev 0.5-3
python3-pil:amd64 10.2.0-1ubuntu1
python3-png 0.20231004.0-2
python3-pyudev 0.24.0-1
python3-qrcode 7.4.2-4
python3.12-dev 3.12.3-1ubuntu0.7

At this point, I cursed Arceus for my woes and switched operating systems.

[TixoRebel]

I'm seeing this exact same error as well on Fedora with the same devkitARM version of GCC.

[resetes12]

I'm also stumped, but maybe I'm the one mistaken, thinking I haven't done extra steps when installing my repository.

Maybe try re-installing agbcc to the project, although I don't know if this affects modern builds though.
Also try make clean-tools and try compiling again, or this to supposedly install devkitARM to use the modern compiler.

Besides that, arm-none-eabi-gcc --version returns that it hasn't been installed on my machine, and I don't know where to look for make modern V=1 2>&1 | head -20 and make V=1 2>&1 | head -10 outputs.

As you can see, I'm not very well-versed in this kind of stuff, but I'm willing to try whatever you guys need in order to help you.

[TixoRebel]

Could you try running /opt/devkitpro/devkitARM/bin/arm-none-eabi-gcc --version? Unfortunately I am already using devkitARM from that link and have tried a clean build.

[resetes12]

Sure, that one works.
arm-none-eabi-gcc (devkitARM release 62) 13.2.0

[friendlymammal]

Thanks for being willing to troubleshoot! Honestly, I'm not very well versed either, so I'm learning as I go.

There are 3 details about your setup that would be helpful to know, whenever you have a chance to open up VSCode and try some commands. You'd run all 3 of these in the terminal, same as if you were running a make modern command.

1. gcc --version should tell us which version of GCC you're using
2. lsb_release -a will tell us information about your Ubuntu install.
3. make modern V=1 2>&1 | head -20 will tell us more details about the compiler commands and flags being used when you run make modern

I've reinstalled agbcc and confirmed I'm working with devkitARM. You're on a slightly older version than the ones I've tried -- I've used 13.2.1 and 15.1.0 so far. I'll try 13.2.0 soon! (If you're curious and want more info on the commands Tixo and I asked about, I've stuck some info in the spoiler).

checking devkitARM versions

• The command that TixoRebel suggested /opt/devkitpro/devkitARM/bin/arm-none-eabi-gcc --version is a way to check which version of devkitARM you're using. You've got an older version (release 62, rather than 66).
• The command that I suggested was asking for the same information, but it didn't work because arm-none-eabi-gcc isn't in your PATH. In other words, it's installed, but the terminal only knows how to handle it using the longer name that TixoRebel used.

[TixoRebel]

Just to clarify a little bit, I think gcc --version would give the version of the system wide GCC, which I don't think is being used here, not the version included in devkitARM. Thankfully we already have the GCC version as that's just the version of arm-none-eabi-gcc.

[friendlymammal]

Thanks for the clarification! I was wondering if make modern might call a different version of gcc compared to arm-none-eabi-gcc, but I could be way off base. I think that make modern V=1 2>&1 | head -20 will give details about which compiler and flags are being used? I'll defer to anyone with more experience though!

[resetes12]

1. gcc --version

gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0

lsb_release -a

No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 22.04.3 LTS
Release: 22.04
Codename: jammy

make modern V=1 2>&1 | head -20

I don't know where the logs end up... :)

I was re-checking old DMs about people asking the same questions, and some of them resolved these same issues (apparently) by installing DevKitPro. Other than that, I would personally recommend doing a make clean and make clean-tools, reinstalling agbcc as Pret's wiki suggests, then installing DevKitARM release 62 (just to be sure, I guess).

I'm 100% sure I followed this WSL1 guide or this one, which is slightly older as I haven't used any other guide outside of Pret's wiki. Other than that, I don't provide any base rom, nor do I store the "pokeemerald" folder in Ubuntu; I store it in Windows.

[friendlymammal]

When I run make modern V=1 2>&1 | head -20 in VS Code's terminal, it prints the output directly beneath the command. In those lines (screenshot), it shows I'm storing pokeemerald in Windows rather than Ubuntu, using WSL (set up using the first link to pret's guide), and compiling using devkitpro/devkitARM.

The only differences I can see between our setups are that you're using older versions of ubuntu and the devkitARM toolchain that came with devkitpro. My best guess is that make modern is running with slightly different compile flags (maybe due to the older versions?).
During testing, I've always used make clean before each build. Aside from reinstalling agbcc, I've also run make clean-tools and compiled other roms, so I know my setup can work in practice some of the time.
Thanks again for helping to troubleshoot! I'd love to switch to 3.0, but if we can't get it figured out, I'll either stick with the older version or wait for a pre-patch to show up elsewhere online.

[resetes12]

Sure, there you go.

Thanks again for helping to troubleshoot! I'd love to switch to 3.0, but if we can't get it figured out, I'll either stick with the older version or wait for a pre-patch to show up elsewhere online.

But, may I ask, what do you mean with this? There are all the .bps files from 1.0.1 up to 3.0 in "Releases". Plus, there are many ways of patching .bps files on Linux. Building the ROM this way is only for people who want to edit my code, which of course I don't mind.

[friendlymammal]

Oof, sorry, you're right. I was planning to edit a little after I got a vanilla version working, but I'll just switch to patching my old version and give up on compiling/editing. (Smh, I hadn't had coffee and wasn't thinking about patches). Thank you again for all your help! Sorry I couldn't figure out what the issue was.

[TixoRebel]

The problem seems to be that version 66 of devkitARM updated to a GCC version which defaulted to c23, which gets rid of a bunch of old features / undefined behavior in the language that this repo relies on. I opened a pull request (#52) to resolve some of these issues and allow this repo to compile with version 65 of devkitARM, which defaults to c17, but some more changes would be required to use c23.