make issues - src/field_player_avatar.c ObjectEventCB2_NoMovement2 parameter name omitted

[judicornadamsfoster]

Hi, I'm getting errors when trying to make the gba file today, the last time i compiled the rom a few days ago I had no issues but since then I have completely reinstalled Windows 11 and then reinstalling WSL / Ubuntu and getting everything set up.

in src/field_player_avatar.c it gives an error for ObjectEventCB2_NoMovement2 for parameter name omitted (screenshot below)

This happens everytime I "git clone" in the last hour or two. I've tried compiling pret's standard master and get no issues. No changes are made to any of the files before running "make modern"

I'm on Win 11 25H2, WSL with Ubuntu 22.04.05 LTS
commands used to set up:
sudo apt-get update
sudo apt-get upgrade
sudo apt-get install build-essentialbinutils-arm-none-eabi git libpng-dev

I also had to set up these to get compiling to work.
sudo apt-get install gcc-arm-none-eabi
sudo apt-get install gdebi-core
wget https://apt.devkitpro.org/install-devkitpro-pacman
chmod +x ./install-devkitpro-pacman
sudo ./install-devkitpro-pacman

[resetes12]

I take it this hasn't been resolved yet?
/usr/lib/gcc/arm-none-eabi/10.3.1/cc1 -quiet -o build/modern/src/field_player_avatar.o src/field_player_avatar.c src/field_player_avatar.c: In function 'ObjectEventCB2_NoMovement2': src/field_player_avatar.c:362:38: error: parameter name omitted 362 | static u8 ObjectEventCB2_NoMovement2(struct ObjectEvent *, struct Sprite *) | ^~~~~~~~~~~~~~~~~~~~ src/field_player_avatar.c:362:60: error: parameter name omitted 362 | static u8 ObjectEventCB2_NoMovement2(struct ObjectEvent *, struct Sprite *) | ^~~~~~~~~~~~~~~ make: *** [Makefile:340: build/modern/src/field_player_avatar.o] Error 1 make: *** Deleting file 'build/modern/src/field_player_avatar.o'

I don't know. People have fixed a couple of issues here and there, but I've never had compiling problems with version 62 to begin with.

The rule is, if you're compiling and it happens, then it hasn't. It's best to use version 62 of the GCC compiler (the one I'm using and i'll continue using) or 65, which should have most issues fixed. Higher versions will require manual fixing from the user.

Figured it out. My dev platform was running an older release of Ubuntu.
Once I did an in-place upgrade to the latest Ubuntu, it compiled just fine after that. Doh!

Originally posted by @iball in #51

Seems like it's the same as this one. Not much (I think) I can do.

[judicornadamsfoster]

Hi again, I played around with the install and done some googling and got it working eventually.

This is how I did it incase it helps anyone else.

1:
open powershell as administrator
wsl --install
restart computer

2
open powershell as administrator again:
wsl --install -d Ubuntu

3
activate windows hypervisor platform in "turn on windows features" if it is turned off

4
open powershell as administrator (this may take a while - took me about 20 minutes)
wsl --set-version Ubuntu 1

5
open Ubuntu from Start menu (set up username and password if it hasn't been done already)
sudo apt-get update && sudo apt-get upgrade
sudo apt-get install build-essential binutils-arm-none-eabi git libpng-dev

sudo apt-get install gcc-arm-none-eabi
sudo apt install gdebi-core
wget https://apt.devkitpro.org/install-devkitpro-pacman
chmod +x ./install-devkitpro-pacman
sudo ./install-devkitpro-pacman

6
set up folder to download/store the files in your Windows user account (I chose Desktop but it can be anywhere)
cd /mnt/c/Users/[user]/Desktop/decomps

7
download the git repository
git clone https://github.com/resetes12/pokeemerald

8
set up agbcc: (Choose ONE option depending on if agbcc has already been setup)
first time set up:
git clone https://github.com/pret/agbcc
cd agbcc
./build.sh
./install.sh ../pokeemerald

built on different terminal than WSL/Ubuntu:
cd agbcc
git clean -fX
./build.sh
./install.sh ../pokeemerald

built before on same terminal as current:
cd agbcc
./install.sh ../pokeemerald

9
build the gba rom:
if not in the "pokeemerald" folder
cd /mnt/c/Users/[user]/Desktop/decomps/pokeemerald (or similar folder depending on your setup choices)
make modern (this will take a while)

Close Ubuntu window / terminal window after it has finished and built gba file