Skip to content

Commit ccf20ab

Browse files
committed
Addresses two todo items
1 parent 74988da commit ccf20ab

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

packages/core/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ class RingCentral implements RingCentralInterface {
231231
await this.restapi(null)
232232
.oauth()
233233
.revoke()
234-
.post({ token: temp, client_id: this.rest.clientId } as any); // todo: spec doesn't allow client_id
234+
.post({ token: temp, client_id: this.rest.clientId });
235235
this.token = undefined;
236236
}
237237

packages/extensions/authorize-uri/src/index.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,13 @@
11
import type RingCentral from "@rc-ex/core";
22
import SdkExtension from "@rc-ex/core/SdkExtension";
3-
// import type AuthorizeRequest from "@rc-ex/core/definitions/AuthorizeRequest";
3+
import type AuthorizeRequest from "@rc-ex/core/definitions/AuthorizeRequest";
44
import type { QueryDataMap } from "urijs";
55
import URI from "urijs";
66

77
export interface AuthorizeUriOptions {
88
baseUri?: string;
99
}
1010

11-
// todo: remove this type when spec updated
12-
type AuthorizeRequest = {
13-
response_type?: string;
14-
client_id?: string;
15-
code_challenge?: string;
16-
code_challenge_method?: string;
17-
redirect_uri?: string;
18-
state?: string;
19-
ui_options?: string;
20-
};
21-
2211
function isNode() {
2312
return typeof process !== "undefined" &&
2413
process.versions?.node != null &&

0 commit comments

Comments
 (0)