chore: use positional arg with default value

Author: eduardacoppo

lib/syskit/network_generation/dataflow_dynamics.rb

@@ -575,7 +575,7 @@ def compute_policies_from(connection_graph, source_task, policy_graph = {})
                             fallback_policy = explicit_policy.delete(:fallback_policy)
                             h[port_pair] = policy_for(
                                 source_task, *port_pair, sink_task,
-                                fallback_policy, explicit_policy: explicit_policy
+                                fallback_policy, explicit_policy
                             )
                         end
                     policy_graph[[source_task, sink_task]] = computed_policies
@@ -632,7 +632,7 @@ def policy_compute_data_element(
 
             def policy_for(
                 source_task, source_port_name, sink_port_name, sink_task,
-                fallback_policy, explicit_policy: {}
+                fallback_policy, explicit_policy={}
             )
                 computed_policy =
                     if explicit_policy[:type]

test/network_generation/test_dataflow_dynamics.rb

@@ -232,8 +232,7 @@ module NetworkGeneration
                     task0.out_port.connect_to(task1.in_port)
 
                     @dynamics.should_receive(:policy_for)
-                             .with(task0, "out", "in", task1, nil,
-                                   explicit_policy: {})
+                             .with(task0, "out", "in", task1, nil, {})
                              .and_return(type: :buffer, size: 42)
                     policy_graph = @dynamics.compute_connection_policies
 
@@ -253,8 +252,7 @@ module NetworkGeneration
                     task0.out_port.connect_to(task1.in_port)
 
                     @dynamics.should_receive(:policy_for)
-                             .with(task0, "out", "in", task1, nil,
-                                   explicit_policy: {})
+                             .with(task0, "out", "in", task1, nil, {})
                              .and_return(type: :buffer, size: 42, init: true)
                     policy_graph = @dynamics.compute_connection_policies
 
@@ -274,8 +272,7 @@ module NetworkGeneration
                     task0.out_port.connect_to(task1.in_port)
 
                     @dynamics.should_receive(:policy_for)
-                             .with(task0, "out", "in", task1, nil,
-                                   explicit_policy: {})
+                             .with(task0, "out", "in", task1, nil, {})
                              .and_return(type: :buffer, size: 42, init: false)
                     policy_graph = @dynamics.compute_connection_policies
 
@@ -293,8 +290,7 @@ module NetworkGeneration
                     cmp.c_child.out_port.connect_to(task.in_port)
 
                     @dynamics.should_receive(:policy_for)
-                             .with(cmp.c_child, "out", "in", task, nil,
-                                   explicit_policy: {})
+                             .with(cmp.c_child, "out", "in", task, nil, {})
                              .and_return(type: :buffer, size: 42)
                     policy_graph = @dynamics.compute_connection_policies
 
@@ -333,8 +329,7 @@ module NetworkGeneration
                     )
 
                     @dynamics.should_receive(:policy_for)
-                             .with(task0, "out", "in", task1, { type: :data },
-                                   explicit_policy: {})
+                             .with(task0, "out", "in", task1, { type: :data }, {})
                              .and_return(type: :buffer, size: 42, init: nil)
 
                     policy_graph = @dynamics.compute_connection_policies