Remove PYARROW_TEST_ANNOTATIONS flag

Author: rok

.github/workflows/python.yml

@@ -241,8 +241,6 @@ jobs:
         run: ci/scripts/python_test.sh $(pwd) $(pwd)/build
       - name: Test annotations
         shell: bash
-        env:
-          PYARROW_TEST_ANNOTATIONS: "ON"
         run: ci/scripts/python_test_type_annotations.sh $(pwd)/python
 
   windows:

ci/scripts/python_test_type_annotations.sh

@@ -20,21 +20,18 @@
 set -ex
 pyarrow_dir=${1}
 
-if [ "${PYARROW_TEST_ANNOTATIONS}" == "ON" ]; then
-  # Install library stubs
-  pip install pandas-stubs scipy-stubs sphinx types-cffi types-psutil types-requests types-python-dateutil
+# Install library stubs
+pip install pandas-stubs scipy-stubs sphinx types-cffi types-psutil types-requests types-python-dateutil
 
-  # Install type checkers
-  pip install mypy pyright ty
+# Install type checkers
+pip install mypy pyright ty
 
-  # Install other dependencies for type checking
-  pip install fsspec
+# Install other dependencies for type checking
+pip install fsspec
 
-  # Run type checkers
-  pushd ${pyarrow_dir}
-  mypy
-  pyright
-  ty check;
-else
-  echo "Skipping type annotation tests";
+# Run type checkers
+pushd ${pyarrow_dir}
+mypy
+pyright
+ty check;
 fi

compose.yaml

@@ -919,7 +919,6 @@ services:
     environment:
       <<: [*common, *ccache, *sccache]
       PYTEST_ARGS:  # inherit
-      PYARROW_TEST_ANNOTATIONS: "ON"
     volumes: *conda-volumes
     command: &python-conda-command
       ["
@@ -1003,7 +1002,6 @@ services:
       ARROW_S3: "OFF"
       ARROW_SUBSTRAIT: "OFF"
       ARROW_WITH_OPENTELEMETRY: "OFF"
-      PYARROW_TEST_ANNOTATIONS: "ON"
       SETUPTOOLS_SCM_PRETEND_VERSION:
     volumes: *ubuntu-volumes
     deploy: *cuda-deploy
@@ -1504,7 +1502,6 @@ services:
         python: ${PYTHON}
     shm_size: *shm-size
     environment:
-      PYARROW_TEST_ANNOTATIONS: "ON"
       <<: [*common, *ccache, *sccache]
       PARQUET_REQUIRE_ENCRYPTION:  # inherit
       HYPOTHESIS_PROFILE:  # inherit
@@ -1536,7 +1533,6 @@ services:
       BUILD_DOCS_CPP: "ON"
       BUILD_DOCS_PYTHON: "ON"
       PYTEST_ARGS: "--doctest-modules --doctest-cython"
-      PYARROW_TEST_ANNOTATIONS: "ON"
     volumes: *conda-volumes
     command:
       ["/arrow/ci/scripts/cpp_build.sh /arrow /build &&