generate bindings job deletes functions from the generated code, but they exist in upstream headers

[esteve]

See for example: #602

The rcl_wait_for_clients and rcl_wait_for_servers functions are removed from the bindings, but they do exist in Rolling (https://github.com/ros2/rcl/blob/rolling/rcl/include/rcl/graph.h#L825 and https://github.com/ros2/rcl/blob/rolling/rcl/include/rcl/graph.h#L862).

Similar issue happened already (#572), but for different functions (rcutils_raw_steady_time_now in that case). Issue was fixed by #582, but it seems it was not the actual solution.

[esteve]

@knmcguire here's the ticket, these are my findings. I haven't been able to reproduce this issue locally, though.

[knmcguire]

very strange! I'll try to take a look as soon as I can 🔍 🕵️‍♀️

[knmcguire]

Ive tried to run the docker container locally on my machine>

So within the repo root:

docker run -it --rm -v ${PWD}:/workspace -w /workspace rostooling/setup-ros-docker:ubuntu-noble-ros-rolling-ros-base-latest /bin/bash

And then in the shell

apt-get update && apt-get upgrade -y
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain 1.85.0 -y
export PATH="$HOME/.cargo/bin:$PATH"
curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
cargo binstall -y bindgen-cli
source /opt/ros/rolling/setup.bash
cd rclrs/src
../generate_bindings.py rcl_wrapper.h rolling .

if I then check the actual diff:

cd /workspace
git diff rclrs/src/rcl_bindings_generated_rolling.rs

There is nothing... so the investigation continues!

@esteve you said you didnt see anything with the script if you ran it locally. With locally, did you run it in an container or directly on your machine?