From fe110ea2f235be198d1ccdf201ed14ed6848324c Mon Sep 17 00:00:00 2001 From: Ivan Santiago Paunovic Date: Thu, 29 Oct 2020 12:25:10 -0300 Subject: [PATCH] Node.__init__() executable and ComposableNode.__init__() plugin arguments aren't optional Signed-off-by: Ivan Santiago Paunovic --- launch_ros/launch_ros/actions/node.py | 2 +- launch_ros/launch_ros/descriptions/composable_node.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/launch_ros/launch_ros/actions/node.py b/launch_ros/launch_ros/actions/node.py index 82764258f..6824d7d57 100644 --- a/launch_ros/launch_ros/actions/node.py +++ b/launch_ros/launch_ros/actions/node.py @@ -69,7 +69,7 @@ class Node(ExecuteProcess): def __init__( self, *, - executable: Optional[SomeSubstitutionsType] = None, + executable: SomeSubstitutionsType, package: Optional[SomeSubstitutionsType] = None, name: Optional[SomeSubstitutionsType] = None, namespace: Optional[SomeSubstitutionsType] = None, diff --git a/launch_ros/launch_ros/descriptions/composable_node.py b/launch_ros/launch_ros/descriptions/composable_node.py index 01352c700..c2fa4abc1 100644 --- a/launch_ros/launch_ros/descriptions/composable_node.py +++ b/launch_ros/launch_ros/descriptions/composable_node.py @@ -35,7 +35,7 @@ class ComposableNode: def __init__( self, *, package: SomeSubstitutionsType, - plugin: Optional[SomeSubstitutionsType] = None, + plugin: SomeSubstitutionsType, name: Optional[SomeSubstitutionsType] = None, namespace: Optional[SomeSubstitutionsType] = None, parameters: Optional[SomeParameters] = None,