Invalid namespace argument succeeds in graph API calls

[jacobperron]

Bug report

Required Info:

• Operating System:
  • Ubuntu 18.04
• Installation type:
  • source
• Version or commit hash:
  • c3ea0df
• DDS implementation:
  • Fast-RTPS
• Client library (if applicable):
  • rcl

Steps to reproduce issue

Uncomment graph API tests:

rcl/rcl/test/rcl/test_graph.cpp

Lines 320 to 324 in 686035e

	// TODO(jacobperron): This succeeds, but should fail due to invalid namespace
	// ret = rcl_get_publisher_names_and_types_by_node(
	// this->node_ptr, &allocator, false, this->test_graph_node_name, "_!invalidNs", &nat);
	// EXPECT_EQ(RCL_RET_ERROR, ret) << rcl_get_error_string().str;
	// rcl_reset_error();

rcl/rcl/test/rcl/test_graph.cpp

Lines 336 to 340 in 686035e

	// TODO(jacobperron): This succeeds, but should fail due to invalid namespace
	// ret = rcl_get_publisher_names_and_types_by_node(
	// this->node_ptr, &allocator, false, this->test_graph_node_name, unknown_node_ns, &nat);
	// EXPECT_EQ(RCL_RET_ERROR, ret) << rcl_get_error_string().str;
	// rcl_reset_error();

rcl/rcl/test/rcl/test_graph.cpp

Lines 404 to 408 in 686035e

	// TODO(jacobperron): This succeeds, but should fail due to invalid namespace
	// ret = rcl_get_subscriber_names_and_types_by_node(
	// this->node_ptr, &allocator, false, this->test_graph_node_name, "_!invalidNs", &nat);
	// EXPECT_EQ(RCL_RET_ERROR, ret) << rcl_get_error_string().str;
	// rcl_reset_error();

rcl/rcl/test/rcl/test_graph.cpp

Lines 420 to 424 in 686035e

	// TODO(jacobperron): This succeeds, but should fail due to invalid namespace
	// ret = rcl_get_subscriber_names_and_types_by_node(
	// this->node_ptr, &allocator, false, this->test_graph_node_name, unknown_node_ns, &nat);
	// EXPECT_EQ(RCL_RET_ERROR, ret) << rcl_get_error_string().str;
	// rcl_reset_error();

rcl/rcl/test/rcl/test_graph.cpp

Lines 488 to 492 in 686035e

	// TODO(jacobperron): This succeeds, but should fail due to invalid namespace
	// ret = rcl_get_service_names_and_types_by_node(
	// this->node_ptr, &allocator, false, this->test_graph_node_name, "_!invalidNs", &nat);
	// EXPECT_EQ(RCL_RET_ERROR, ret) << rcl_get_error_string().str;
	// rcl_reset_error();

rcl/rcl/test/rcl/test_graph.cpp

Lines 504 to 508 in 686035e

	// TODO(jacobperron): This succeeds, but should fail due to invalid namespace
	// ret = rcl_get_service_names_and_types_by_node(
	// this->node_ptr, &allocator, this->test_graph_node_name, unknown_node_ns, &nat);
	// EXPECT_EQ(RCL_RET_ERROR, ret) << rcl_get_error_string().str;
	// rcl_reset_error();

Build:

    colcon build --packages-up-to rcl

Run tests:

    colcon test --packages-select rcl

Or run the graph test specifically:

    build/rcl/test/test_graph__rmw_fastrtps_cpp

Expected behavior

All tests pass.

Actual behavior

The uncommented tests fails.

Additional information

Appears the graph API calls are succeeded when a failure is expected. This is likely a bug in the rmw implementation or a misunderstanding about what constitutes a valid namespace.

[clalancette]

I'm pretty sure this was fixed by #498, so closing. Feel free to reopen if I'm wrong about that.