Original images in Media all wont load - Sanity check failed for destination path: String expected error

[dubbsdubblin]

After updating to the latest version (0.25.10) - All of the original PNG/JPEG files in the media browser are broken - when I try and view the original uploaded file I get a "Sanity check failed for destination path: String expected" error in the browser. Can you advise what the issue is please - If I disable WebP Express - the media browser loads the images without issue and I can view the original uploaded files.

I am using "Varied image response" setting to alter the HTML to serve the webp version of the uploaded original image.

If I use the "Testing redirection to converter" option - I also get the "Sanity check failed for destination path: String expected" error here on uploaded images.

This was not an issue when running Version 0.25.8.

Many thanks.

[rosell-dk]

ah, not good.
I will try to fix asap, which probably means this evening

Thanks for reporting!

[rosell-dk]

Hm, I cannot reproduce.

I'm wondering if you could check the error log?

It should show what the destination path actually was (now that it was not a string), as this is logged in the file "lib/classes/SanityCheck.php", line 30.

Can you post the output you get from clicking "System Info" on the WebP Express settings page? (its in the upper right corner in the "General" section). This might reveal the problem

@dubbsdubblin

[rosell-dk]

You could also try adding these two line in lib/classes/WebPOnDemand.php, line 196:
echo 'destination:' . $destination;
exit;

When running the "Testing redirection to converter" test, below "Body", you will see the new output, which will be "destination:" - and then something - which I'm very curious to know what is...

[dubbsdubblin]

Hm, I cannot reproduce.

I'm wondering if you could check the error log?

It should show what the destination path actually was (now that it was not a string), as this is logged in the file "lib/classes/SanityCheck.php", line 30.

Can you post the output you get from clicking "System Info" on the WebP Express settings page? (its in the upper right corner in the "General" section). This might reveal the problem

@dubbsdubblin

[dubbsdubblin]

echo 'destination:' . $destination;
exit;

Did that for you: Results are:

Uploads:
Body:
destination:
However. As the "content-type" header reveals, we did not get a webpSurprisingly we got: "text/html; charset=UTF-8"
The test FAILED.
Deleting test images

Themes:
Body:
destination:/home/sites/32a/2/248ba18ec6/public_html/wp-content/webp-express/webp-images/themes/webp-express-test-images/MepQZi.JPEG.webp
However. As the "content-type" header reveals, we did not get a webpSurprisingly we got: "text/html; charset=UTF-8"
The test FAILED.
Deleting test images

[rosell-dk]

Thanks,

I tried the same configuration as you, but it does not fail for me.
But it narrows down debugging, so thanks!

From you last post, I can see that nothing is printed after "destination:". That is a good clue.
I also notice that destination is calculated for themes, so I assume that the test works for the themes image root, right?

[dubbsdubblin]

From you last post, I can see that nothing is printed after "destination:". That is a good clue. I also notice that destination is calculated for themes, so I assume that the test works for the themes image root, right?

I am not sure what you mean here sorry

[rosell-dk]

Thats ok, was mainly thinking out loud :)

Can you try replacing the debugging in lib/classes/WebPOnDemand.php, line 196 with the following?

    echo 'Debugging getDestination call: ' . "\n";
    echo 'source:' . $source;
    echo ', destination-folder:' . $wodOptions['destination-folder'];
    echo ', destination-extension:' . $wodOptions['destination-extension'];
    echo ', webExpressContentDirAbs: ' . self::$webExpressContentDirAbs;
    echo ', $uploadDirAbs:' . $uploadDirAbs;
    echo ', usingDocRoot: ' . self::$usingDocRoot;
    echo ', imageRootsDef:' . print_r(self::getImageRootsDef(), true);
    exit;

That extra information would be very helpful

@dubbsdubblin

[rosell-dk]

I unfortunately have to go now, but I will continue as soon as I can (probably this evening)

[dubbsdubblin]

Thats ok, was mainly thinking out loud :)

Can you try replacing the debugging in lib/classes/WebPOnDemand.php, line 196 with the following?

    echo 'Debugging getDestination call: ' . "\n";
    echo 'source:' . $source;
    echo ', destination-folder:' . $wodOptions['destination-folder'];
    echo ', destination-extension:' . $wodOptions['destination-extension'];
    echo ', webExpressContentDirAbs: ' . self::$webExpressContentDirAbs;
    echo ', $uploadDirAbs:' . $uploadDirAbs;
    echo ', usingDocRoot: ' . self::$usingDocRoot;
    echo ', imageRootsDef:' . print_r(self::getImageRootsDef(), true);
    exit;

That extra information would be very helpful

@dubbsdubblin

[dubbsdubblin]

I unfortunately have to go now, but I will continue as soon as I can (probably this evening)

Thanks

[rosell-dk]

Thanks again, @dubbsdubblin

This is tricky and I'm going to need your help again.

Can you please try inserting following debug instead of the old debug in the same place as before? ( lib/classes/WebPOnDemand.php, line 196), and show me the result?

Sorry about the hazzle

    echo 'WE_HTACCESS_ID:' . self::getEnvPassedInRewriteRule('WE_HTACCESS_ID');
    $dirIdOfHtaccess = self::getEnvPassedInRewriteRule('WE_HTACCESS_ID');
    if ($dirIdOfHtaccess === false) {
        echo 'not passed in env';
        $dirIdOfHtaccess = SanityCheck::noControlChars($_GET['htaccess-id']);
    }
    echo ', dirIdOfHtaccess' . $dirIdOfHtaccess;
    if (!in_array($dirIdOfHtaccess, ['uploads', 'themes', 'wp-content', 'plugins', 'index'])) {
        echo 'invalid htaccess directory id argument.';
    }

    $sourceRelHtaccess = self::getEnvPassedInRewriteRule('WE_SOURCE_REL_HTACCESS');
    echo ', WE_SOURCE_REL_HTACCESS: ' . $sourceRelHtaccess;
    // Otherwise use query-string
    if ($sourceRelHtaccess === false) {
      if (isset($_GET['xsource-rel-htaccess'])) {
          $x = SanityCheck::noControlChars($_GET['xsource-rel-htaccess']);
          $sourceRelHtaccess = SanityCheck::pathWithoutDirectoryTraversal(substr($x, 1));
          echo 'sourceRelHtaccess from query string: ' . $sourceRelHtaccess;
      } else {
        echo 'Argument for source path is missing';
      }
    }

    $sourceRelHtaccess = SanityCheck::pathWithoutDirectoryTraversal($sourceRelHtaccess);
    echo ', sourceRelHtaccess' . $sourceRelHtaccess;
    echo ', source calc: ' . self::getImageRootsDef()->byId($dirIdOfHtaccess)->getAbsPath() . '/' . $sourceRelHtaccess;

    echo 'using doc root: ' . (self::$usingDocRoot ? 'yes' : 'no');
    echo ', source (before url decode): ', self::getSource();
    echo ', source (after url decode):' . $source;
    $sourceResolved = realpath($source);
    echo ', $sourceResolved: ' . $sourceResolved;

    $rootPath = self::getImageRootsDef()->byId('uploads')->getAbsPath();
    echo ', upload abs path:' . print_r($rootAbsPath, true);
    echo ', upload abs, realpath:' . print_r(realpath($rootAbsPath), true);

    if (strpos($sourceResolved, realpath($rootPath)) !== false) {
        echo ', path was found';
        $relPath = substr($sourceResolved, strlen(realpath($rootPath)) + 1);
        echo ', relPath: ' . $relPath;
        $relPath = ConvertHelperIndependent::appendOrSetExtension($relPath, 'separate', 'append', false);
        echo ', path result:' . self::$webExpressContentDirAbs . '/webp-images/uploads/' . $relPath;
    } else {
        echo 'not found';
    }

[rosell-dk]

just noticed that the source does look strange in your previous output:
"source:/home/sites/32a/2/248ba18ec6/public_html/wp-content/uploads//home/sites/32a/2/248ba18ec6/public_html/wp-content/uploads/webp-express-test-images/fy9gFr.JPEG"...

So I updated the debug code above in order to debug the steps of calculating $source.
Just to let you know that the above code has been updated

[rosell-dk]

I think I finally figured out the bug.
One moment