Skip to content
This repository was archived by the owner on Oct 19, 2018. It is now read-only.
This repository was archived by the owner on Oct 19, 2018. It is now read-only.

Change ./ext/string requires to react/ext/string #55

@sollycatprint

Description

@sollycatprint

From @makevoid on August 7, 2015 13:17

I've found that there is a require error trying to bundle the code if the the ext/string path is not absolute (gem dir / path)

I think it works well when you are requiring the gem via path: "./.." like you do in the examples (in fact they work) but it breaks otherwise

fiy I'm on 2.1.6

Here's how to reproduce:

Gemfile

source "http://rubygems.org"

gem "react.rb", github: "zetachang/react.rb"

build.rb

require 'bundler'
Bundler.require

Opal::Builder.build('react')

run:

bundle && ruby build.rb

this pr should fix it

there is also some whitespace removal, If you want I can take it out from this PR and have just the two require lines as modified

also, very cool library! I will start to play with it soon! thanks!

Copied from original issue: zetachang/react.rb/pull/55

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions