Skip to content

Common: check_expired_locked_rules use SQLalchemy #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voetberg wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Common: check_expired_locked_rules use SQLalchemy #160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4073c36
Common: Upgrade to python3 #127
voetberg Sep 23, 2025
fb473d7
Common: Update header #127
voetberg Sep 23, 2025
ec4b89b
Common: Upgrade probe to sqla2.0 #127
voetberg Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 53 additions & 20 deletions common/check_expired_locked_rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,28 @@
#!/usr/bin/env python
# Copyright European Organization for Nuclear Research (CERN) 2013
#!/usr/bin/env python3
# Copyright European Organization for Nuclear Research (CERN) since 2012
#
# Licensed under the Apache License, Version 2.0 (the "License");
# You may not use this file except in compliance with the License.
# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# Authors:
# - Cedric Serfon, <cedric.serfon@cern.ch>, 2015
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

'''
Probe to check the locked expired rules or datasets with locked rules
'''

import sys
from datetime import datetime

from sqlalchemy import and_, select, null, true

from rucio.db.sqla import models
from rucio.db.sqla.session import get_session

# Exit statuses
Expand All @@ -25,28 +35,51 @@ def main():
'''
status = OK
session = get_session()

base_statement = select(
models.ReplicationRule.id,
models.ReplicationRule.name,
models.ReplicationRule.scope,
models.ReplicationRule.rse_expression,
)

try:
query = "select rawtohex(id), scope, name, rse_expression from atlas_rucio.rules where locked=1 and expires_at<sys_extract_utc(localtimestamp)"
print 'Locked expired rules'
for row in session.execute(query):
expired_locked_rules = base_statement.where(
and_(
models.ReplicationRule.locked == true(),
models.ReplicationRule.expires_at < datetime.utcnow() # see https://github.com/rucio/rucio/issues/6476
)
)
print('Locked expired rules')
for row in session.execute(expired_locked_rules):
status = CRITICAL
print row[0], row[1], row[2]
print(row[0], row[1], row[2])

Copy link
Contributor

@dchristidis dchristidis Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line (and the similar one you introduced later) produces a curious grouping. According to PEP 8:

Use blank lines in functions, sparingly, to indicate logical sections.

A try and its associated except statements are typically part of the same section. It would make more sense to introduce a blank line before the second try statement and before the last sys.exit(status) call.

except Exception as error:
print error
print(error)
status = UNKNOWN
sys.exit(status)
try:
query = """select rawtohex(c.id), c.scope, c.name, c.rse_expression from atlas_rucio.rules c,
(select a.scope, a.name from atlas_rucio.dids a
where a.expired_at is not null and a.expired_at < sys_extract_utc(localtimestamp)
and exists (select 1 from atlas_rucio.rules b where a.scope=b.scope and a.name=b.name and locked=1)) d
where c.scope=d.scope and c.name=d.name and locked=1"""
print 'Datasets expired with locked rules'
for row in session.execute(query):
dids_of_locked_expired_rules = base_statement.join(
models.DataIdentifier,
and_(
models.ReplicationRule.scope == models.DataIdentifier.scope,
models.ReplicationRule.name == models.DataIdentifier.name,
),
).where(
and_(
models.ReplicationRule.locked == true(),
models.DataIdentifier.expired_at != null(),
models.DataIdentifier.expired_at < datetime.utcnow() # see https://github.com/rucio/rucio/issues/6476
)
)
print('Datasets expired with locked rules')
for row in session.execute(dids_of_locked_expired_rules):
status = CRITICAL
print row[0], row[1], row[2], row[3]
print(row[0], row[1], row[2], row[3])

except Exception as error:
print error
print(error)
status = UNKNOWN
sys.exit(status)
sys.exit(status)
Expand Down