-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Currently, Entry & Feed constructors set the provided $id param directly to $id properties. On get(), $this-id is checked that it's not an empty string and returned.
In the FeedFactory, the $id param is checked in validateRequiredFeedElements() to ensure its not an empty string.
PR #21 implemented URI/IRI validation for id:elements provides RFC 3986 & 3987 compliance/validation for the $id param (Atom id:element).
It would be better to utilize League/Uri::createFromString() when supplying the $id constructor param in factories to help ensure a model object always contains a valid & compliant $id property.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request